Repository navigation
docs: route learning capture through editable source owners - #808
Conversation
|
Requested |
ss-o
left a comment
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on e2fcafe
Findings
No actionable findings. Reviewed the complete editable-source and generated-runbook diff against f4ce1685 and checked its owner links against the delivery records.
Note
This is a maintainer-elected self-review, not an independent review or approval to merge.
Checklist and validation
- Source ownership and generation: PASS. The matrix names the declared organization-policy and implementation-pattern sources, routes generated destinations through delivery records, and preserves project-native ownership until approved delivery. All 57 generated consumers are current.
- Completion and evidence semantics: PASS. Provisional capture is not presented as promotion; useful candidates receive a disposition in existing evidence; silent
No durable learningremains valid without a new artifact. Missing pilot records remain unknown outcomes, not zero counts. - Links and coverage: PASS. Local Markdown targets resolve and source owners agree with delivery records. All 366 repository files are accounted for. Only the source and its generated runbook change.
- Deterministic checks: PASS. All 21 knowledge tests pass locally, with earlier 176 policy/routing tests and pinned Markdown lint evidence retained. All 12 current-head hosted checks pass, including agent-instruction validation, routing, links, policy and CodeQL. Instruction evidence, routing evidence.
- Scope and privacy: PASS. No runtime settings, policy pins or manifests change; public guidance does not introduce private environment details.
Limits and follow-up
The single configured Copilot request did not register; request evidence distinguishes the existing team request from a Copilot registration. Cause is unconfirmed. The maintainer explicitly elected this fallback for the current head. No unresolved review threads exist. The retrospective pilot evaluation was not performed; #806 remains open for that work. This does not prove cross-runtime adoption. GitHub Markdown rendering is checked; narrow-screen visual rendering is unverified.
Summary
Refs #806. Correct the learning-capture destination matrix to name editable knowledge-domain sources instead of generated consumers. Regenerate the maintained runbook from
knowledge/domains/governance/learning-capture.md.flowchart LR A[Verified learning candidate] --> B[Find declared editable owner] B --> C[Update source within authority] C --> D[Regenerate and verify consumers]Distinguish provisional local findings, locally applied corrections and published promotion. Require a useful candidate's disposition in existing evidence without manufacturing extra artifacts for
No durable learning. Preserve project-native ownership until approved delivery is complete and treat missing pilot records as evidence gaps, not zero outcomes.Verification
Agent handoff
The destination and disposition correction is ready for current-head hosted checks and review. Keep #806 open to retain the outstanding retrospective pilot evaluation: that evaluation was not performed here, and no rollout-wide or cross-runtime adoption claim is made.