Skip to content

ci(lint): pin the released-analyzer contract to zsh-lint v1.5.0 - #807

Merged
ss-o merged 1 commit into
mainfrom
ci/zsh-lint-1-5-0
Oct 16, 2026
Merged

ss-o merged 1 commit into
mainfrom
ci/zsh-lint-1-5-0

Conversation

@ss-o

@ss-o ss-o commented Oct 16, 2026

Copy link
Copy Markdown
Member

Moves the Released Analyzer Contract job in zsh-lint-test.yml from zsh-lint v1.4.0 to v1.5.0, and updates the knowledge source knowledge/domains/ci/zsh-lint-ci.md and its generated runbooks/zsh-lint-ci.md to name v1.5.0.

Part of z-shell/zsh-lint#612. zsh-lint v1.5.0: https://github.com/z-shell/zsh-lint/releases/tag/v1.5.0 (signed tag on b3b9fdc). The parser fork is now part of the analyzer's root module and the analyzer needs Go 1.27; the reusable workflow already builds ./cmd/zsh-lint from the checkout root and reads Go from the analyzer's go.mod, so it needs no change.

Verification

  • v1.5.0 built from the tag the way the reusable workflow builds it, then automation/ci/zsh_lint_ci.py --mode strict on automation/ci/fixtures/zsh-lint/clean.txt exits 0 and writes the full report.
  • python3 -m unittest automation/ci/test_zsh_lint_ci.py passes (13 tests).
  • knowledge-delivery.py --check (57 consumers), knowledge-coverage.py, validate-agent-policy.py, org-routing.py validate, git diff --check and trunk check --no-fix --ci on the three files pass.

This repository's Renovate preset would repin only the workflow; this change keeps the documented version in step with it.

@ss-o
ss-o requested a review from a team as a code owner October 16, 2026 22:52

@ss-o ss-o left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback review under ADR-0026: maintainer elected after the Copilot request did not register, on dfac8f6

Findings

No actionable findings. The three one-line changes move the Released Analyzer Contract job's zsh-lint-ref from v1.4.0 (aff6018) to v1.5.0 (b3b9fdc) and name v1.5.0 in the knowledge source and its generated runbook, which stay byte-consistent (knowledge-delivery.py --check passes).

Checklist verdicts

  • Pin: pass. b3b9fdce3799827755ae546d2185e3d85063e6db is the commit the signed v1.5.0 tag points to. The reusable workflow builds ./cmd/zsh-lint from the checkout root and reads Go from the analyzer's go.mod, which matches v1.5.0's root-module layout and Go 1.27.
  • Behavior: pass. v1.5.0 built the way the workflow builds it passes zsh_lint_ci.py --mode strict on the clean fixture, and the 13 test_zsh_lint_ci.py tests pass. The hosted Released Analyzer Contract / Zsh Lint job, which runs the reusable workflow with v1.5.0, also passes on this head.
  • Checks: pass. Coverage, agent policy, routing validation, whitespace and Trunk pass locally; all 14 hosted checks pass; the commit signature is verified.

This is an author-side review of record, not independent human approval. No threads or comments were open at publication.

@ss-o
ss-o merged commit 1b9f042 into main Oct 16, 2026
14 checks passed
@ss-o
ss-o deleted the ci/zsh-lint-1-5-0 branch October 16, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant