Repository navigation
ci(lint): pin the released-analyzer contract to zsh-lint v1.5.0 - #807
Merged
Merged
Conversation
ss-o
commented
Oct 16, 2026
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: maintainer elected after the Copilot request did not register, on dfac8f6
Findings
No actionable findings. The three one-line changes move the Released Analyzer Contract job's zsh-lint-ref from v1.4.0 (aff6018) to v1.5.0 (b3b9fdc) and name v1.5.0 in the knowledge source and its generated runbook, which stay byte-consistent (knowledge-delivery.py --check passes).
Checklist verdicts
- Pin: pass.
b3b9fdce3799827755ae546d2185e3d85063e6dbis the commit the signed v1.5.0 tag points to. The reusable workflow builds./cmd/zsh-lintfrom the checkout root and reads Go from the analyzer'sgo.mod, which matches v1.5.0's root-module layout and Go 1.27. - Behavior: pass. v1.5.0 built the way the workflow builds it passes
zsh_lint_ci.py --mode stricton the clean fixture, and the 13test_zsh_lint_ci.pytests pass. The hostedReleased Analyzer Contract / Zsh Lintjob, which runs the reusable workflow with v1.5.0, also passes on this head. - Checks: pass. Coverage, agent policy, routing validation, whitespace and Trunk pass locally; all 14 hosted checks pass; the commit signature is verified.
This is an author-side review of record, not independent human approval. No threads or comments were open at publication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
Released Analyzer Contractjob inzsh-lint-test.ymlfrom zsh-lint v1.4.0 to v1.5.0, and updates the knowledge sourceknowledge/domains/ci/zsh-lint-ci.mdand its generatedrunbooks/zsh-lint-ci.mdto name v1.5.0.Part of z-shell/zsh-lint#612. zsh-lint v1.5.0: https://github.com/z-shell/zsh-lint/releases/tag/v1.5.0 (signed tag on
b3b9fdc). The parser fork is now part of the analyzer's root module and the analyzer needs Go 1.27; the reusable workflow already builds./cmd/zsh-lintfrom the checkout root and reads Go from the analyzer'sgo.mod, so it needs no change.Verification
automation/ci/zsh_lint_ci.py --mode strictonautomation/ci/fixtures/zsh-lint/clean.txtexits 0 and writes the full report.python3 -m unittest automation/ci/test_zsh_lint_ci.pypasses (13 tests).knowledge-delivery.py --check(57 consumers),knowledge-coverage.py,validate-agent-policy.py,org-routing.py validate,git diff --checkandtrunk check --no-fix --cion the three files pass.This repository's Renovate preset would repin only the workflow; this change keeps the documented version in step with it.