ci: close issues resolved by a next-to-main promotion #523

Activity

1. ss-o

   added

   type:maintenanceNon-feature maintenance, cleanup, or org work.Non-feature maintenance, cleanup, or org work.

   area:ciContinuous integration or GitHub Actions work.Continuous integration or GitHub Actions work.

   meta:org-trackedIndicates this issue has cross-repository tracking implications (synced to Linear).Indicates this issue has cross-repository tracking implications (synced to Linear).

   on Aug 18, 2026
2. github-project-automation

   added this to Z-shell Deliveryon Aug 18, 2026
3. github-project-automation

   moved this to Triage in Z-shell Deliveryon Aug 18, 2026
4. ss-o commented on Sep 30, 2026

   

   ss-o

   on Sep 30, 2026

   MemberAuthor

   More actions

   Project 28 triage pass. Blank values filled on this issue (existing values left unchanged):

   • Impact: Medium. Recurs after every merge wave on next, and the backlog overstates open work (eight issues in one review).
   • Effort: S. The proposed first step is one checklist step in the branching ADR and the zi promotion gate.
5. ss-o commented on Oct 1, 2026

   

   ss-o

   on Oct 1, 2026

   MemberAuthor

   More actions

   Project 28 triage pass (2026-10-02): stays in Triage.

   • Premise check on main at b849468 (premise confirmed): At b849468 runbooks/pull-requests.md section 4 says 'Close those issues by hand when next is promoted to main, not earlier (zi's AGENTS.md)' and zi AGENTS.md@next line 35 says the same, but neither decisions/0008-branching-model.md, decisions/0016, decisions/0028 nor runbooks/release.md 'Zi promotion publication' contains a promotion-time 'close issues resolved by this promotion' step (grep for close/resolved: no match). zi#377 and .github#513 are CLOSED; no merged PR references ci: close issues resolved by a next-to-main promotion #523.
   • Proposed disposition: implement, once the open points below are agreed.
   • Unknowns and next investigation: Unknown: whether the maintainer considers the existing pull-requests.md section-4 rule plus zi AGENTS.md sufficient (then close-completed), or wants the explicit checklist step in runbooks/release.md 'Zi promotion publication' (and/or ADR-0008), and whether automation that reads the keyword qualifier is in scope or explicitly out. Next: maintainer picks the home (release.md step vs ADR-0008 vs close as covered); if a step is wanted it is a one-paragraph docs PR.
6. ss-o commented on Oct 8, 2026

   

   ss-o

   on Oct 8, 2026

   MemberAuthor

   More actions

   Disposition: automate. The maintainer chose closing at promotion time over a checklist step.

   • ci(promotion): close issues delivered by a next promotion zi#596 adds the Promotion Issue Closure workflow. On a push to main that is a merged next to main promotion, it closes each issue a promoted pull request names in an unqualified closing clause, with a comment naming the promotion. The two cases above stay open: Refs #364 is not a closing clause, and Closes #360 after ... is qualified. Both kinds, plus cross-repository references and issue URLs, are listed in the run summary for a manual check.
   • GitHub's closingIssuesReferences is not used: it is empty for zi#592 although the body says Closes #538., so the workflow parses pull request bodies.
   • docs(runbooks): close zi issues by workflow at promotion #763 updates runbooks/pull-requests.md; it should merge after zi#596 is promoted to main.

   This issue can close once zi#596 is promoted and the first promotion run is checked.
7. ss-o

   added 4 commits that reference this issue on Oct 8, 2026

   fix(promotion): report edited bodies and late qualified clauses

   ...

   448d656

   ci(promotion): close issues delivered by a next promotion (#596)

   ...

   4a9db10

   fix(promotion): retry late PR lookup and list sidebar-linked issues (#…

   ...

   4ecb9de

   docs(runbooks): name edited bodies and the manual close in zi

   ...

   cb6044c
8. ss-o commented on Oct 8, 2026

   

   ss-o

   on Oct 8, 2026

   MemberAuthor

   More actions

   Delivered by z-shell/zi#596 and z-shell/zi#603, with the organization runbook updated in #763. Promotion z-shell/zi#617 exercised the workflow successfully on main commit 199bbcafddde93ab22f3fcf9e000e81ac3a75385: https://github.com/z-shell/zi/actions/runs/37786546853.

   The workflow reads unqualified closing keywords from the merged constituent PRs, preserves reference-only and qualified statements, and reports sidebar-linked issues for review. The reviewed parser and workflow tests cover those exclusions. Issue z-shell/zi#615 was closed by this promotion.
9. ss-o

   closed this as completedon Oct 8, 2026