WIP: Right to Left (RTL) support (YPE-4818) - #406
Draft
cameronapak wants to merge 5 commits into
Draft
cameronapak wants to merge 5 commits into
cameronapak wants to merge 5 commits into
Conversation
Browser-specific RTL scrollLeft models made scroll-offset heuristics place the highlight swatch fade masks incorrectly. Measure the first and last swatches against the row viewport instead, mapping logical start/end to physical edges by direction. Also add a Storybook locale toolbar toggle and RTL integration stories for the bible reader and swatch overflow.
🦋 Changeset detectedLatest commit: 4158a3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cameronapak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
pnpm testpnpm typecheckpnpm lintpnpm exec turbo build --force