Repository navigation
Conversation
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Retries after a 502/503 response or a connection error now wait a random time between 50% and 150% of the previous fixed delay: 1–3 s instead of 2 s after 502/503, and 0.05–0.15 s instead of 0.1 s after a connection error. Clients that failed at the same moment no longer retry at the same moment.
Context: ynput/ayon-launcher#129.
Additional info
When many clients start at once (e.g. 200 new farm machines running the AYON launcher) and the server answers 503, they all retried exactly 2 s later, hitting the server together again. Random delays spread the retries out.
The average delay stays the same, so the total wait time doesn't change. Exponential backoff would ease the load further, but it would also make failing requests wait longer, so it isn't part of this PR.
Testing notes:
pytest tests/test_request_retries.py(no server needed).