Repository navigation
fix: reader keys, short screen info menu and lighter first loads - #53
Merged
Merged
Conversation
- in pages mode, space on a focused button, link or toggle presses it instead of turning the page; arrows still turn pages - the info menu scrolls when a short screen can't fit it - a zoom click made while the viewer is still loading opens once it is ready, and opens the image itself if the viewer fails to load - the background video pauses on comic pages, which cover it, and for visitors who ask for less motion - phones no longer preload the comic art below their first screen - homepage images take their real sizes from the files at build time
|
Deploy preview for y-fu ready!
Deployed with vercel-action |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a review of the Astro build. I verified each finding in the code and the browser first.
Tested in the browser:
I couldn't reproduce the zoom race, so that fix is verified by reading the code. Lint,
astro checkand the build pass.