Skip to content

fix: reader keys, short screen info menu and lighter first loads - #53

Merged
banteg merged 1 commit into
mainfrom
fix/review-findings
Oct 30, 2026
Merged

banteg merged 1 commit into
mainfrom
fix/review-findings

Conversation

@banteg

@banteg banteg commented Oct 30, 2026

Copy link
Copy Markdown
Member

Fixes from a review of the Astro build. I verified each finding in the code and the browser first.

  • Reader keys: in Pages mode, pressing Space on a focused button (Play, Next, Zoom…) turned the page and blocked the button. Now Space presses a focused button, link or text toggle. Arrow keys still turn pages wherever focus is, and Space still turns pages when nothing is focused.
  • Info menu: on short screens (844×390) the menu ran past the bottom and its links couldn't be reached. It's now capped at the space below the header and scrolls.
  • Zoom while loading: the viewer loads on demand, and a click before it finished loading did nothing. Clicks now wait for it. If the viewer can't load, for example after a deploy replaced its files, the click opens the image itself.
  • Background video: it kept playing behind the comic reader's opaque page. It now pauses on comic pages and resumes elsewhere. It also stays paused for visitors who ask for reduced motion, who were already shown the still poster instead.
  • Preload: phones no longer preload the 211 KB comic art, which sits below their first screen. Screens 48rem and wider still preload it.
  • Image sizes: homepage images now get their real sizes, read from the files at build time with sharp, as the tribute pages already do. The Temple art had claimed to be 600×895 but is 1000×1365.

Tested in the browser:

  • Space on Play plays music without turning the page; Space and the arrow keys still turn pages.
  • The menu fits and scrolls at 844×390.
  • Zoom opens and closes.
  • The video pauses in the reader and resumes after going back.
  • No console errors.

I couldn't reproduce the zoom race, so that fix is verified by reading the code. Lint, astro check and the build pass.

- in pages mode, space on a focused button, link or toggle presses it
  instead of turning the page; arrows still turn pages
- the info menu scrolls when a short screen can't fit it
- a zoom click made while the viewer is still loading opens once it is
  ready, and opens the image itself if the viewer fails to load
- the background video pauses on comic pages, which cover it, and for
  visitors who ask for less motion
- phones no longer preload the comic art below their first screen
- homepage images take their real sizes from the files at build time
@github-actions

Copy link
Copy Markdown

Deploy preview for y-fu ready!

Project:y-fu
Status: ✅  Deploy successful!
Preview URL:https://y-n6zkaihn2-yearn.vercel.app
Latest Commit:852cee6

Deployed with vercel-action

@banteg
banteg merged commit ab93985 into main Oct 30, 2026
3 checks passed
@banteg
banteg deleted the fix/review-findings branch October 30, 2026 16:07
@banteg
banteg restored the fix/review-findings branch October 30, 2026 16:08
@banteg
banteg deleted the fix/review-findings branch October 30, 2026 16:08

This branch was successfully deployed

1 active deployment
preview — 852cee67 Deployed Oct 30, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant