Repository navigation
chore: drop the asset scripts and their source paths - #46
Merged
Merged
Conversation
the comic, artwork and audio encoders only ran once against masters on one machine, so they live on in git history. comics.json keeps the page sizes the site uses but loses each page's source path, which the reader pages were also shipping in their html
|
Deploy preview for y-fu ready!
Deployed with vercel-action |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
scripts/:import-comics.mjs,encode-assets.mjsandencode-audio.mjs. They encoded the comic pages, gallery artwork and soundtrack once, from masters on one machine, so they live on in git history. The README now says so and points toscripts/at 455bd69, instead of listing local paths to the masters.content/comics.jsonstays, because the site reads each page's size and widths from it. It loses thesourcefield each page carried, with values like2024-04-17 fix bigbadabook/yFu_01 Full 04172024.pdf p1. Nothing read that field, but because the reader and comics list are React islands, Astro serialized it into every comic page's HTML. Issue 1's page carried 27 such paths.A build diffed against main differs only in the comic pages. Once the removed
sourceentries and the prop-derivedastro-island uids are ignored, they're byte-identical. Each reader page is about 2.5 KB smaller. Lint andastro checkpass.