Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A successful HIGH currently suppresses CRITICAL for an hour, and a failed webhook is forgotten once the alert hook returns. Persist destination-specific deliveries before HTTP, let CRITICAL bypass HIGH's cooldown, and drain retries every minute without requiring another alert.
Preserves the existing liquidity-monitoring endpoint, credentials and payload. Optional vaults-mommy delivery has its own secret, endpoint, cooldown and retry state; its signed payload adds a stable event ID. Exact payload bytes and IDs survive restarts and uncertain acknowledgements. SQLite FULL transactions and expiring leases keep concurrent monitor processes coordinated without holding database locks during HTTP.
Timeouts/408/429/5xx retry with bounded backoff. Other HTTP failures remain terminal for explicit correction; redirects are not followed. Operator retry preserves ID/body, can explicitly adopt a corrected endpoint, and never happens automatically after endpoint changes. DEBUG retains queued work without sending. Secrets are not persisted.
Validation: 2,087 passed, 4 skipped, 108 subtests passed in the full monitoring suite; Ruff lint/format,
ty check, and all repository prek hooks pass. Tests cover HIGH at t=0 and CRITICAL at t=20m, both destinations, unavailable destination/restart, unchanged liquidity envelope, exact-byte HMAC, uncertain acknowledgement, lease races, concurrency, terminal errors and missing credentials.Sender portion of vaults-mommy #29, following epic #27. Receiver and real cross-repository integration follow the shared bootstrap PR; this PR alone does not qualify or enable vault exits. No live dispatch, signing or production activation was performed. Independent review/activation approvals remain in vaults-mommy #35.