Repository navigation
test: drop config-data assertions, keep logic tests - #445
Merged
Merged
Conversation
Remove tests that only pinned specific config entries (vault addresses, risk tiers, labels, RPC URLs, note text) and decouple logic tests from live config by using synthetic fixtures. Fixes CI on main after the Katana Morpho vault cleanup in cee092d. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
mainbroke (run) becausecee092dremoved Katana Morpho vaults, and two tests depended on those config entries. This PR removes tests that only check config data and changes logic tests to use synthetic fixtures, so editing a config won't break CI.Removed (config pins only):
test_morpho_markets: Katana collateral vault address set, Robinhood market risk tiers, Robinhood explorer URLtest_morpho_governance: assertion that HyperEVM is a configured chaintest_known_addresses: lookups of specific Yearn Safe, proposer bot, Safe utility and timelock labelstest_lender_borrower: accumulator strategy address pintest_pegged_assets: required-asset list, "BTC wrappers are downside-only"test_risk_anchors: hardcoded list of registered Safe selectors, "enableModule is CRITICAL"test_threejane_context: note-text pins, list of known ProtocolConfigLib keystest_web3_wrapper: HyperEVM public RPC URL pintest_3jane,test_stables_oracles:DISPATCHABLE_PROTOCOLSmembership pinsRewritten to use synthetic fixtures instead of live config:
VAULTS_V1_BY_CHAIN), andanalyze_v2_vaultrunning the low-liquidity check_watched_safe_labels: explicit label, fallback label, unknown network skippedPeggedAsset.is_depegged: symmetric, BTC peg, downside-onlyIGNORED_TRANSACTION_SENDERS)protocolKept on purpose: checks that apply to every entry in a table and catch malformed data, e.g. selectors match their signatures, names are unique, depeg tolerance is positive, Safe labels are valid env-var suffixes. Also kept: the
jobs.yaml↔monitoring.yamlconsistency checks that CLAUDE.md documents.Test plan
uv run pytest -q: 1986 passed, 4 skippeduv run ruff check ./ruff format --check .🤖 Generated with Claude Code