Repository navigation
Conversation
pngToBmp checked R, G and A against the threshold, so transparent white pixels were turned into ink and bright low-blue strokes (e.g. a yellow pen) were dropped as background. Check R, G and B instead. Fixes yashlamba#92
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92
pngToBmpthresholded on R, G and alpha instead of R, G and B. Transparent white pixels(255, 255, 255, 0)were classified as ink, and bright low-blue strokes such as a yellow pen(255, 255, 0, 255)were dropped as background. This changes the check topix[2].Added
test_pngToBmp_thresholdtotests/test_pngtosvg.py. It covers opaque white, transparent white, black and yellow pixels, and it fails without the fix.black --check .passes. I couldn't run the potrace/fontforge-dependent tests locally because neither tool is installed here; they fail the same way on unmodifiedmain.