Skip to content

Fix language server startup with debugging enabled - #158

Merged
Frotty merged 2 commits into
masterfrom
codex/fix-debug-appcds
Oct 8, 2026
Merged

Frotty merged 2 commits into
masterfrom
codex/fix-debug-appcds

Conversation

@Frotty

@Frotty Frotty commented Oct 8, 2026

Copy link
Copy Markdown
Member

With wurst.debugMode enabled, the language server starts Java with both the JDWP native agent and AutoCreateSharedArchive. Java aborts before LSP initialization with 'CDS dumping does not support native JVMTI agent, name: jdwp', producing repeated disposed-connection and EPIPE errors.

Skip AppCDS creation for debug sessions and custom JVM agent options while preserving debugging and ordinary-session AppCDS. The compatibility guard runs before archive probing or cleanup.

Validation: reproduced the failure with the installed Java 25 runtime and compiler; the same command without AppCDS succeeds. TypeScript typecheck, lint, npm test, and diff checks pass. Regression tests cover debug startup flags, normal startup, and custom agent options.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T18:46:29.668199Z 35234ef Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 188af8be7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/install/fsUtils.ts Outdated
@Frotty

Frotty commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 35234efd23

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Frotty
Frotty merged commit 28d0067 into master Oct 8, 2026
1 check passed
@Frotty
Frotty deleted the codex/fix-debug-appcds branch October 8, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant