Repository navigation
Resolve Warcraft file aliases when loading model textures - #155
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScrollOfTownPortal.mdx requests Textures/GenericGlow2_mip1.blp, which Warcraft resolves through FileAliases.json to Textures/GenericGlow2.blp. The extension searched only physical archive paths, leaving the glow texture missing and producing filled particle squares.
The CASC adapter now resolves the installed game's aliases, including BLP/DDS/TGA variants for texture entries. Alias tables are loaded lazily and shared per installation storage. Direct files keep precedence, archive namespaces are preserved, and alias chains terminate safely on cycles. Map-local resolution continues to run before game archive lookup.
Validation: TypeScript, ESLint, npm test, extension build, and all 127 browser end-to-end tests passed. Regression tests cover the glow alias, HD namespaces, model alias chains, cycles, direct-file precedence, table caching, and installations without alias tables. The reported scroll was rendered with installed Warcraft data through the updated adapter and had zero missing textures.