Skip to content

Improve object editor asset previews and controls - #154

Merged
Frotty merged 3 commits into
masterfrom
codex/objmod-asset-controls
Oct 8, 2026
Merged

Frotty merged 3 commits into
masterfrom
codex/objmod-asset-controls

Conversation

@Frotty

@Frotty Frotty commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Object editor model previews were confined to a tiny single-line badge, choosing another asset required entering edit mode first, and refreshing the detail header could leave its icon spinning. The object action bar also lost its padding because its CSS shorthand expanded to an invalid value.

Model previews now span both value lines at 36px in compact mode and 40px in cozy mode. Editable asset fields offer a direct Browse button, including empty and placeholder values. Refreshed header icons reuse the icon loader, and action buttons have density-aware padding and gaps. Asset field edit and undo/redo cycles target the enclosing table cell, keeping one wrapper; undoing to a placeholder clears the preview.

Validation:

  • Webpack build, extension and webview TypeScript checks, ESLint, and npm test passed.
  • Initial full browser run: all 130 tests passed.
  • Follow-up full browser run: 130 passed; the existing deletion/reindexing test exceeded its 30-second limit. It passed on a targeted rerun with a 60-second limit (38.4 seconds).
  • All six final asset-control browser regressions passed, covering direct selection, loaded-icon header refresh, thumbnail size, both density modes, repeated editing/undo/redo, and choosing/saving assets into empty and placeholder fields.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T12:28:44.378091Z b8c34ae Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11fb8c6b3f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/webview/objModEditor/fieldDisplay.ts
@Frotty

Frotty commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3eee88d10a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/webview/objModEditor/fieldDisplay.ts
@Frotty

Frotty commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: b8c34aece3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Frotty
Frotty merged commit aba280e into master Oct 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant