Repository navigation
Report invalid input Jass instead of dropping it - #1429
Merged
Merged
Conversation
The Jass grammar let a type be empty, so `local hero = "h"` parsed as a local without a type. Translating it threw a NullPointerException, which AntlrJassParseTreeTransformer swallowed: the declaration and the rest of the file were dropped with no error, and the build shipped the result. The same held for an untyped global or parameter, `local array a` and a missing return type, and `call f integer(x)` was accepted as `call f(x)`. - Jass.g4: jassTypeExpr has no empty alternative, and exprFunctionCall no longer takes a type between the name and the arguments. - The transformer reports a NullPointerException as an error at the declaration it failed in, rather than ignoring it. - WurstAntlrErrorListener re-evaluates its whitespace check while moving an error's start back. It never re-evaluated it, so an error at the end of the file or at a newline was reported at the file's first character.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 135b39cb40
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Jass grammar allowed an empty type, so
local x = 1parsed without error. The transformer then hit a NullPointerException and swallowed it, so the declaration and the rest of the file were dropped silently.Jass.g4: no empty type, no type slot in function callsTests:
JassSyntaxErrorTests,CliBuildMapTests.theCliBuildFailsOnInvalidJassInTheMapScript.