Repository navigation
Support string keys in FastKeyedMap - #1408
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5dcb1e859
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Frotty
changed the title
1 participant
FastKeyedMap currently excludes string keys despite Lua supporting them directly. This change lets the same new-generic API use
FastKeyedMap<string, int>and string keys with class-reference values.Companion stdlib PR: wurstscript/WurstStdlib2#507.
String specializations select same-package, annotated Jass fallbacks with collision-safe storage. Generic has/remove lower alongside put/get, and the IM interpreter selects those fallbacks using resolved type arguments. Lua reads remain direct table indices with typed defaults; writes/removal use the existing minimal table-operation intrinsics. The legacy handle API remains compatible.
Validation: all 35 LuaKeyedMapTests passed, including Jass and Lua execution, interpreter execution, full-string hash collisions, stored zero, class values, destroy/reuse, and byte-identical repeated emission. The stdlib typecheck and all 525 tests passed with an isolated compiler build on Java 27.
Supported types: handle and string keys. The source parameter is K:; stronger source-level key constraints/earlier diagnostics and integer/class keys remain follow-ups. Jass values remain int/class references. The pinned stdlib commit belongs to the companion PR and must be coordinated before merge.