Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d82704f79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| actual=$("$JAVA_BIN" -jar build/dist/slim-${{ matrix.plat }}/wurst-compiler/wurstscript.jar -version) | ||
| test "$actual" = "$RELEASE_VERSION" |
There was a problem hiding this comment.
In the windows-latest matrix job, this runs native java.exe under Git Bash. System.out.println emits CRLF on Windows, while Bash command substitution strips the trailing LF but retains the \r, so actual becomes 2.0.0\r and cannot equal RELEASE_VERSION. Because publish requires the entire build matrix, every release is blocked at this check; strip the carriage return or otherwise normalize the captured output before comparing.
Useful? React with 👍 / 👎.
This branch has not been deployed
1 participant
Every master push currently republishes nightly, so development commits immediately become compiler updates. This replaces that flow with deliberate versioned releases starting at 2.0.0. Master/PR CI continues to test but no longer packages or publishes nightly.
Companion extension draft: wurstscript/wurst4vscode#150. Explicit version choices stay pinned until users select Follow latest stable.
The release workflow accepts only vMAJOR.MINOR.PATCH tags matching version.txt, pointing at the checkout and belonging to origin/master. All four platforms run tests and package the compiler before one publication job assembles the complete release. Existing published release assets cannot be replaced. Checksums accompany the platform ZIPs.
Exact release tags print a plain semantic version; other builds print VERSION-dev+COMMIT. Release preparation and the transition order are documented in docs/RELEASING.md: merge the compiler workflow, publish v2.0.0, then ship the companion extension. No actual compiler tag or release is created by this PR.
Validation: six release-gate tests with real Git histories; production Gradle metadata checks for nightly/exact annotated release/post-release commits; MainTests; shadowJar; Windows slim runtime packaging and bundled-runtime -version check; actionlint and diff checks. Four-platform CI and actual GitHub publication remain to run after review/merge and release tagging.