Repository navigation
feat(benchmark): support alternative program calls - #631
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
A
program-callscheck can now listalternatives: [{"call": ..., "args": {...}}, ...]instead of onecall/args. Each enabled call node matching any alternative counts once against the sharedmin/max; overlapping alternatives cannot inflate the count. The existing single-call form, event selection, bounded reads, and unavailable-content behavior remain intact.The benchmark guide and SPEC-414 document the format. Tests reuse Proximity-repel in OPY and both Workshop locales, and add Workshop fixtures for array removal, filtering with either
!=operand order, and a negative that includes the event player. Existing single-call tests are unchanged.Validation
origin/mainraisesKeyError('call')for alternatives-only checks; this branch counts each equivalent form once, including overlapping alternatives.git diff --checkpasses. No Rust code changed; Rust gates were not run locally.Fixes #630