Repository navigation
feat(protocol): add canonical id resolution via lpp/resolveIds - #56
Merged
Merged
Conversation
LPP 1.6 adds the optional resolveIds capability: a project-independent, bounded, deterministic map from canonical Workshop ids (calls, and enum members grouped by domain) to the language's spellings. An id with no spelling is omitted, never guessed, and a request over 1024 ids is rejected rather than truncated. The mock provider maps a small fixed table for x-demo-lang. Fixtures cover mapping and omission, the bound, the version gate, the absent capability, an invalid language, and invalid params. ADR-0006 records the decision. Fixes #55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds LPP 1.6
lpp/resolveIdsbehind the optionalresolveIdscapability. Fixes #55. Parent decision: wrightkit/wright#615.Decision (ADR-0006)
lpp/resolveIds, capabilityresolveIds, protocol version 1.6, additive minor.{ languageId, calls?: [id], enums?: { domain: [member] } }.{ calls: { id: spelling }, enums: { domain: { member: spelling } } }, only requested ids the language spells.-32602, never truncated.lpp/lookup, a flat{kind, id}array, a provider-declared maximum.Verification
Evidence level: the reference mock provider against the repository fixtures. This does not show a real provider (
opy-rs) implements the capability.cargo fmt --all --check,cargo clippy --all-targets -- -D warnings,cargo test --workspace,git diff --check: pass.--validate-onlyand against the mock provider: 67 passed, 0 failed (6 new fixtures).