Repository navigation
Give the Docker workers the PHP settings of the host as their php.ini - #423
Conversation
As a file in conf.d, the settings were also loaded by processes that pass a configuration file of their own, which on the host replaces them. With memory_limit = -1 on the GitHub runners, the custom ini scenario of server-command (wp server --config) got -1 instead of its own 512M. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Primary PHP configuration mount utils/behat-parallel.php |
The settings file mount targets /usr/local/etc/php/php.ini. Comments describe the replacement and clarify that processes started with their own configuration file do not receive these settings. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Suggested labels: bug, scope:testing, scope:distribution
Suggested reviewers: brianhenryie
Merge Risk: 
Minimal · up to d2fcb
-
No actionable merge-blocking risk remains; the configuration precedence change is ready to merge.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The Docker workers get the host's settings for error reporting,
memory_limitand so on from a file mounted intoconf.d. PHP loadsconf.deven for a process started withphp -c <file>, but on the host such a file replaces thephp.iniand the settings in it. So in the containers a scenario's own configuration file was overridden.This broke
Custom ini configurationin server-command (wp server --config=custom.iniwithmemory_limit = 512M): on the GitHub runners the host hasmemory_limit = -1, which won. server-command's main has been red since Docker workers were switched on (e.g. https://github.com/wp-cli/server-command/actions/runs/41472580912).The file is now mounted as the container's
php.ini. The official PHP images don't ship one, so nothing else gets replaced. Checked inphp:8.3-cliwith the host file holdingmemory_limit = -1:php -rphp -c custom.ini -rconf.d/zz-wp-cli-tests-host.ini(before)php.ini(now)composer phpcs,phpstanandphpunit --filter TestBehatParallelpass.🤖 Generated with Claude Code
Summary by CodeRabbit