[schlessera]

Follow-up to #408.

A run in Docker containers removes them in shutdown functions, which PHP skips when a signal ends the process. Stopping a run with Ctrl+C or timeout, or killing it, left its containers running: the database containers are started detached, so nothing else removes them.

Signals

When the pcntl extension is available, SIGINT, SIGTERM and SIGHUP end the run through exit() (with 130, 143 and 129), so the shutdown functions remove the containers. The run with scenarios selected by path now waits for its container in PHP instead of in passthru(), so the handlers run there as well. Without pcntl, nothing changes.

Leftovers of killed runs

Every container gets a wp-cli-tests.owner=<host>:<pid> label. Before starting containers, a run removes the labelled containers of this host whose process no longer exists. That covers SIGKILL, crashes and reboots, and it is safe:

• Containers of a run that is still going are kept, as its process exists.
• Containers of other hosts sharing the Docker daemon are kept, as only this host's are checked.
• Containers without the label, such as those of other tools, are never touched.
• A process ID that was reused since can only keep containers longer, never remove those of a run that is going.

Testing

Locally, 2 workers in Docker unless noted:

Case	Result
SIGTERM to the runner	Both containers removed within 2 s, exit code 143
SIGINT to the process group (Ctrl+C)	Both containers removed
SIGTERM to a run of scenarios selected by path (single container)	Container removed, exit code 143
SIGKILL to the runner	2 containers left, removed by the next run: "Removed 2 Docker containers that earlier runs left behind."
Next run while another run is going, with dummy containers of a dead process on this host, of another host and without the label	Only the dead process's container removed
Full suite, 4 workers	113 scenarios passed

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 43 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 759ee6e4-8fac-4f02-a7e7-f526bbc30d3a

Commits

Reviewing files that changed from the base of the PR and between 035668f and 4e69782.

Files selected for processing: 2

• .readme-partials/USING.md
• utils/behat-parallel.php

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!