Skip to content

Use cached plugin and theme installs in tests - #1186

Merged
schlessera merged 1 commit into
mainfrom
measure/cached-extension-installs
Nov 2, 2026
Merged

schlessera merged 1 commit into
mainfrom
measure/cached-extension-installs

Conversation

@schlessera

@schlessera schlessera commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Switches the feature files to the these installed plugins: / these installed themes: steps from wp-cli/wp-cli-tests#404, and requires wp-cli/wp-cli-tests ^5.4.0.

Measured on this test suite: Behat time -2.6% (547.0 → 532.9 job minutes, summed over the matrix). Details in wp-cli/wp-cli-tests#404.

Summary by CodeRabbit

  • Tests
    • Updated the Requests v2 test scenario to activate the Twenty Ten theme as an installed theme, rather than attempting to install it during the scenario.
  • Chores
    • Updated development tooling compatibility settings. These changes affect testing and development workflows only; no end-user features or behavior changed.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 59b5fde5-383b-4e83-be95-7852bc87efcb
Commits

Reviewing files that changed from the base of the PR and between f64f0ce and 00adfe9.

Files ignored due to path filters: 1
  • composer.lock is excluded by !**/*.lock
Files selected for processing: 2
  • composer.json
  • features/requests.feature

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The pull request updates the wp-cli/wp-cli-tests development dependency constraint and changes the WordPress-bundled Requests v2 scenario to declare the twentyten theme as installed.

Changes: Test dependency

Layer / File(s) Summary
Update test dependency constraint
composer.json
The wp-cli/wp-cli-tests constraint changes from ^5 to ^5.4.0.

Requests scenario

Layer / File(s) Summary
Declare the theme as installed
features/requests.feature
The scenario declares twentyten as installed and removes the command that installs it.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: swissspidy

Merge Risk: Minimal · up to 00adf

The dependency and cached theme fixture changes are ready to merge; only normal runtime validation remains.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Use cached plugin and theme installs in tests" matches the main change. The PR switches feature tests to the installed plugin and theme steps from wp-cli-tests #404 and raises the wp-cli-te…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Use cached plugin and theme installs in tests" matches the main change. The PR switches feature tests to the installed plugin and theme steps from wp-cli-tests #404 and raises the wp-cli-tests constraint to ^5.4.0. The title names the purpose and the affected area, and it is specific enough for a teammate scanning history to understand the primary change.

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the scope:testing Related to testing label Oct 30, 2026
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@schlessera
schlessera force-pushed the measure/cached-extension-installs branch from efa6226 to 00adfe9 Compare November 2, 2026 02:57
@schlessera schlessera changed the title [DO NOT MERGE] Test wp-cli/wp-cli-tests#404 Use cached plugin and theme installs in tests Nov 2, 2026
@schlessera
schlessera marked this pull request as ready for review November 2, 2026 02:57
@schlessera
schlessera requested a review from a team as a code owner November 2, 2026 02:57
@schlessera
schlessera merged commit c4a0322 into main Nov 2, 2026
56 checks passed
@schlessera
schlessera deleted the measure/cached-extension-installs branch November 2, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant