Skip to content

Use cached plugin and theme installs in tests - #115

Merged
schlessera merged 1 commit into
mainfrom
measure/cached-extension-installs
Nov 2, 2026
Merged

schlessera merged 1 commit into
mainfrom
measure/cached-extension-installs

Conversation

@schlessera

@schlessera schlessera commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Switches the feature files to the these installed plugins: / these installed themes: steps from wp-cli/wp-cli-tests#404, and requires wp-cli/wp-cli-tests ^5.4.0.

Measured on this test suite: Behat time +0.8% (36.1 → 36.3 job minutes, summed over the matrix). Details in wp-cli/wp-cli-tests#404.

Summary by CodeRabbit

  • Tests
    • Updated import-command test scenarios to run with the importer already installed and active. Coverage continues to include file output, missing files, custom importers, standard input, URL imports, and local attachment sources. Expected command behavior remains unchanged.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b464df38-95a6-4243-8a8a-d99ee1515d49
Commits

Reviewing files that changed from the base of the PR and between be31030 and 91a1982.

Files selected for processing: 2
  • composer.json
  • features/import.feature

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The development dependency constraint for wp-cli/wp-cli-tests changed from ^5 to ^5.4.0. Eight import scenarios now use an installed, active wordpress-importer fixture instead of running a plugin installation command. Import commands and expectations remain unchanged.

Changes: Import test setup

Layer / File(s) Summary
Use the importer fixture in import scenarios
composer.json, features/import.feature
The development dependency constraint changes from ^5 to ^5.4.0. Eight scenarios set up wordpress-importer as installed and active instead of running a plugin installation command. Their import commands and stated expectations remain unchanged.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: swissspidy

Merge Risk: Minimal · up to 91a19

The cached importer setup introduces no identified merge-blocking risk. The change appears mergeable subject to normal checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Use cached plugin and theme installs in tests" matches the main change. The PR switches feature files to the cached these installed plugins: and these installed themes: steps and raises…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Use cached plugin and theme installs in tests" matches the main change. The PR switches feature files to the cached these installed plugins: and these installed themes: steps and raises the wp-cli-tests dependency to ^5.4.0, which provides those steps. The title is specific and describes the primary change. It does not cover the composer constraint or the individual scenario edits, which is acceptable.

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the scope:testing Related to testing label Oct 30, 2026
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@schlessera
schlessera force-pushed the measure/cached-extension-installs branch from c7ee47e to 91a1982 Compare November 2, 2026 02:56
@schlessera schlessera changed the title [DO NOT MERGE] Test wp-cli/wp-cli-tests#404 Use cached plugin and theme installs in tests Nov 2, 2026
@schlessera
schlessera marked this pull request as ready for review November 2, 2026 02:56
@schlessera
schlessera requested a review from a team as a code owner November 2, 2026 02:56
@schlessera
schlessera merged commit 37a685e into main Nov 2, 2026
52 checks passed
@schlessera
schlessera deleted the measure/cached-extension-installs branch November 2, 2026 03:01
@schlessera schlessera added this to the 3.0.2 milestone Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant