Skip to content

Run setup commands in a single process in tests - #679

Merged
schlessera merged 1 commit into
mainfrom
measure/setup-commands-step
Nov 2, 2026
Merged

schlessera merged 1 commit into
mainfrom
measure/setup-commands-step

Conversation

@schlessera

@schlessera schlessera commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Switches the feature files to the these setup commands: step from wp-cli/wp-cli-tests#400, and requires wp-cli/wp-cli-tests ^5.4.0.

Measured on this test suite: Behat time +1.0% (887.6 → 896.3 job minutes, summed over the matrix). Details in wp-cli/wp-cli-tests#400.

Summary by CodeRabbit

  • Tests
    • Updated scenario setup across comment counting and deletion, menu listing and locations, option listing, post and taxonomy queries, signup, application passwords, CSV imports, user listing and metadata, and session management.
    • Existing commands, test inputs, and expected results remain unchanged, with setup steps grouped together before the command under test.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 08eb162f-2049-430d-acba-f142a61c8a17
Commits

Reviewing files that changed from the base of the PR and between ffde3e3 and e6c4dd7.

Files selected for processing: 13
  • features/comment-recount.feature
  • features/comment.feature
  • features/menu-location.feature
  • features/menu.feature
  • features/option-list.feature
  • features/post.feature
  • features/signup.feature
  • features/user-application-password.feature
  • features/user-import-csv.feature
  • features/user-list.feature
  • features/user-meta.feature
  • features/user-session.feature
  • features/user.feature

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

Walkthrough

The feature scenarios now group pre-test commands in setup-command tables across comment, menu, option, post, signup, and user tests. The summarized commands and expected outputs remain unchanged.

Changes: Feature scenario setup

Layer / File(s) Summary
Content and query scenario setup
features/comment-recount.feature, features/comment.feature, features/menu-location.feature, features/menu.feature, features/option-list.feature, features/post.feature
Comment, menu, option, and post scenarios move setup commands into tables. The post taxonomy scenario captures category IDs in table save columns and uses those placeholders when creating a post.
Signup scenario setup
features/signup.feature
Six scenarios list the existing signup-creation commands in setup-command tables.
User scenario setup
features/user-application-password.feature, features/user-import-csv.feature, features/user-list.feature, features/user-meta.feature, features/user-session.feature, features/user.feature
User scenarios move setup commands into tables. The spam-management scenario saves command outputs as BBEE_ID and OP_ID in the table.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: swissspidy, danielbachhuber, caribe

Merge Risk: Minimal · up to e6c4d

The feature setup changes are consistent with the supported setup-command contract and introduce no identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: running test setup commands in a single process.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (13 skipped: 13 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the scope:testing Related to testing label Oct 30, 2026
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@schlessera
schlessera force-pushed the measure/setup-commands-step branch from 43135fb to e6c4dd7 Compare November 2, 2026 04:08
@schlessera schlessera changed the title [DO NOT MERGE] Test wp-cli/wp-cli-tests#400 Run setup commands in a single process in tests Nov 2, 2026
@schlessera
schlessera marked this pull request as ready for review November 2, 2026 04:08
@schlessera
schlessera requested a review from a team as a code owner November 2, 2026 04:08
@schlessera
schlessera merged commit c95f423 into main Nov 2, 2026
60 checks passed
@schlessera
schlessera deleted the measure/setup-commands-step branch November 2, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant