Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of my attempt of reducing GC pressure and reducing heap waste. The old approach of reading values was storing the reading methods with a generic object return type. This causes value types to get boxed and allocated on the heap which of course creates unnecessary waste.
We now copy values whenever possible (with a few exceptions when parsing IDs). My local benchmarks when loading 332 DBC storages have improved loading times by about 0.2 seconds: from 1.65 seconds down to 1.37
-- I am currently still in the process of evalulating further bottlenecks, so this is a draft for now
As of right now, these changes bring about 10 - 15% performance improvement.
There are some free gains which came with modern .NET releases that are currently not available because we still support .net standard 2.1 so we might also start discussing if we still want to maintain it or go for supporting only the latest supported .NET releases