Repository navigation
fix(session): Reject non-user access tokens in session cookies - #70
Merged
Merged
Conversation
AuthKitCore.verifyToken now requires sid and auth_time, a sub_profile that is absent or user, and no sub_type, so other token types signed by the same environment key do not authenticate a session. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
Original prompt from madison.packer
|
Contributor
Devin Review🟢 Devin Review found nothing to fix · View findings |
Contributor
[Critical impact] This PR appears safe to merge. Summary
No new actionable issues were found. Tests were not run during this review. Reviews (2) · Last reviewed commit: "test: Authenticate again with the refres..." · Reviewed by Greptile |
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
@greptileai review |
nicknisi
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthKitCore.verifyToken, whichvalidateAndRefreshuses, only ranjwtVerify(signature,exp, andisswhen configured). It didn't check that the token was a user session access token, so other token types signed by the same environment key were accepted as a session.This matches
hasRequiredAccessTokenClaimsin@workos-inc/node.sub_profileis optional on user access tokens, so a missing claim is still accepted. Adapters built onauthkit-sessionpick this up when they upgrade.TokenManager.verifyTokenhas the same plainjwtVerify, but nothing insrcuses it outside its own spec, so this PR leaves it alone.Tests:
AuthKitCore.verifyToken() token claimsinAuthKitCore.issuer.spec.tscoverssub_profile: ai_agent,sub_type: authkit, a missing or stringauth_time, and a missing or numericsid, plussub_profile: useras the positive case. All 6 rejection cases fail without theAuthKitCore.tschange. The spec's default mocked payload now carriessid/auth_time.Link to Devin session: https://app.devin.ai/sessions/7e123fc2545a49c282b043a4abd58f70
Open in Devin Desktop: https://app.devin.ai/desktop/session/7e123fc2545a49c282b043a4abd58f70?variant=devin
Requested by: @m0tzy