Fenrir fixes Sep 4 26 - #295
Open
aidankeefe2022 wants to merge 6 commits into
Open
aidankeefe2022 wants to merge 6 commits into
aidankeefe2022 wants to merge 6 commits into
Conversation
Client throughput benchmark compares an unread receive buffer after timeout error out when tcp_select does not return ready to recive
Client throughput sizes above INT_MAX become negative record lengths fix: increased the size of the variable to size_t
s_client port parser silently truncates ports above 65535 parse into long before loading in to word16 and report/error if it does not fit
Ipv6 DTLS and SCTP connections use IPv4 sockets and omit the DTLS peer Fix: set the correct socket family and set the DTLS peer correctly
Added free for allocation in zephr build swapped free for XFREE
aidankeefe2022
force-pushed
the
fenrir-fixes-sep4-26
branch
from
October 2, 2026 22:46
d827339 to
de88de9
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Benchmark failure paths lack targeted regression coverage, and platform-dependent transport changes need human validation.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Hardens wolfCLU’s client argument parsing, networking, and benchmark error handling.
Changes:
- Validates port and throughput arguments.
- Fixes address cleanup, IPv6 socket handling, and benchmark failure paths.
- Adds invalid-port regression tests and shares filesystem-skip logic.
| File | Description |
|---|---|
| tests/wolfclu_test.py | Adds a shared filesystem-support skip helper. |
| tests/client/client-test.py | Adds port validation tests and uses the shared helper. |
| src/client/client.c | Hardens parsing, networking, and benchmark cleanup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1185
to
+1189
| if (select_ret != TEST_RECV_READY) { | ||
| printf("SSL_read bench select error %d!\n", select_ret); | ||
| err = WOLFSSL_FATAL_ERROR; | ||
| errMsg = (select_ret == TEST_TIMEOUT) ? | ||
| "SSL_read timeout" : "SSL_read select failed"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Fenrir fixes for client.c in wolfCLU.