New IO utils and Base64 fixes by aidankeefe2022 · Pull Request #286 · wolfSSL/wolfCLU

aidankeefe2022 · 2026-08-31T22:49:08Z

Added read/write io functions that can be used to interact with any file pointer

Fix for Fenrir finding : https://fenrir.wolfssl.com/finding/11088

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #286

Scan targets checked: wolfclu-bugs, wolfclu-src

Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #286

Scan targets checked: wolfclu-bugs, wolfclu-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #286

Scan targets checked: wolfclu-bugs, wolfclu-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

fixed + hallucinations

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #286

Scan targets checked: wolfclu-src, wolfclu-bugs

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #286

Scan targets checked: wolfclu-src, wolfclu-bugs

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #286

Scan targets checked: wolfclu-src, wolfclu-bugs

Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Picking on future feature to allow wolfCLU to not need filesystem not in scope for this fix

aidankeefe2022 · 2026-09-14T22:11:35Z

Planning on expanding this file interface to the rest of the codebase but for now starting with base64

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #286

Scan targets checked: wolfclu-src, wolfclu-bugs

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Out of scope change

…ile pointer

added more tests for io for base64 and rewrote IO system for base64 looking to extend in the future

Copilot

Copilot review overview

🟡 Changes recommended

Large-stream capacity handling is not portable, and several intended buffer-boundary tests target incorrect sizes.

Review effort: Balanced
Findings: 1 · 3

Open (4)

Keep stream buffer capacity unsigned · New
Correct comment to document caller-provided read limit · New
Use unsigned formatting for word32 limit · New
Test actual buffer growth boundaries · New

What changed in this PR

Adds reusable file/stream I/O to prevent Base64 stdin truncation.

Changes:

Introduces dynamically growing I/O helpers.
Migrates Base64 processing to the new helpers.
Adds build integration and expanded regression tests.

File	Description
`wolfclu/include.am`	Installs the new header.
`wolfclu/clu_io.h`	Defines the public I/O API.
`src/tools/clu_io.c`	Implements stream/file operations.
`src/tools/clu_base64.c`	Uses the new I/O abstraction.
`src/include.am`	Adds the implementation to Autotools.
`wolfCLU.vcxproj`	Adds files to the Visual Studio build.
`wolfCLU.vcxproj.filters`	Categorizes the new project files.
`tests/base64/base64-test.py`	Adds long-input and I/O regression coverage.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

aidankeefe2022 self-assigned this Aug 31, 2026

aidankeefe2022 requested a review from wolfSSL-Fenrir-bot August 31, 2026 22:49

aidankeefe2022 force-pushed the fenrir-11088 branch from 1b35e33 to 556dc5a Compare August 31, 2026 22:55

wolfSSL-Fenrir-bot requested changes Aug 31, 2026

View reviewed changes

Comment thread src/tools/clu_io.c Outdated

Comment thread src/tools/clu_base64.c Outdated

Comment thread src/tools/clu_io.c Outdated

Comment thread src/tools/clu_io.c Outdated

aidankeefe2022 commented Sep 1, 2026

View reviewed changes

Comment thread src/tools/clu_base64.c Outdated

aidankeefe2022 commented Sep 1, 2026

View reviewed changes

Comment thread src/tools/clu_io.c Outdated

aidankeefe2022 commented Sep 1, 2026

View reviewed changes

Comment thread src/tools/clu_io.c Outdated

aidankeefe2022 commented Sep 1, 2026

View reviewed changes

Comment thread src/tools/clu_io.c Outdated

aidankeefe2022 requested a review from wolfSSL-Fenrir-bot September 1, 2026 15:46

wolfSSL-Fenrir-bot requested changes Sep 1, 2026

View reviewed changes

Comment thread src/tools/clu_io.c Outdated

Comment thread src/tools/clu_io.c Outdated

aidankeefe2022 commented Sep 1, 2026

View reviewed changes

Comment thread src/tools/clu_io.c Outdated

aidankeefe2022 commented Sep 1, 2026

View reviewed changes

Comment thread src/tools/clu_io.c Outdated

aidankeefe2022 assigned wolfSSL-Bot and unassigned aidankeefe2022 Sep 1, 2026

aidankeefe2022 requested a review from wolfSSL-Fenrir-bot September 1, 2026 23:00

wolfSSL-Fenrir-bot previously requested changes Sep 1, 2026

View reviewed changes

Comment thread src/tools/clu_io.c Outdated

Comment thread src/tools/clu_io.c Outdated

aidankeefe2022 commented Sep 2, 2026

View reviewed changes

Comment thread src/tools/clu_io.c Outdated

aidankeefe2022 force-pushed the fenrir-11088 branch from df9086c to a022b83 Compare September 2, 2026 20:06

aidankeefe2022 commented Sep 2, 2026

View reviewed changes

Comment thread src/tools/clu_io.c Outdated

aidankeefe2022 force-pushed the fenrir-11088 branch from a022b83 to dc4ea63 Compare September 2, 2026 21:26

aidankeefe2022 assigned aidankeefe2022 and unassigned wolfSSL-Bot Sep 9, 2026

aidankeefe2022 requested a review from wolfSSL-Fenrir-bot September 9, 2026 21:42

wolfSSL-Fenrir-bot requested changes Sep 9, 2026

View reviewed changes

Comment thread src/tools/clu_io.c Outdated

Comment thread src/tools/clu_io.c Outdated

aidankeefe2022 force-pushed the fenrir-11088 branch from dc4ea63 to d704e25 Compare September 11, 2026 20:53

aidankeefe2022 requested a review from wolfSSL-Fenrir-bot September 11, 2026 20:53

wolfSSL-Fenrir-bot requested changes Sep 11, 2026

View reviewed changes

Comment thread src/tools/clu_io.c Outdated

aidankeefe2022 force-pushed the fenrir-11088 branch from d704e25 to 8b856ef Compare September 11, 2026 21:02

aidankeefe2022 requested a review from wolfSSL-Fenrir-bot September 11, 2026 21:02

wolfSSL-Fenrir-bot previously requested changes Sep 11, 2026

View reviewed changes

Comment thread wolfclu/clu_header_main.h Outdated

Comment thread src/tools/clu_io.c Outdated

Comment thread src/tools/clu_io.c Outdated

aidankeefe2022 assigned wolfSSL-Bot and aidankeefe2022 and unassigned aidankeefe2022 and wolfSSL-Bot Sep 11, 2026

aidankeefe2022 force-pushed the fenrir-11088 branch from 8b856ef to bc07bd8 Compare September 11, 2026 21:52

aidankeefe2022 requested a review from wolfSSL-Fenrir-bot September 11, 2026 21:52

aidankeefe2022 force-pushed the fenrir-11088 branch from a025563 to dbeb34a Compare September 14, 2026 22:17

aidankeefe2022 requested review from wolfSSL-Fenrir-bot and removed request for wolfSSL-Fenrir-bot September 14, 2026 22:51

wolfSSL-Fenrir-bot previously requested changes Sep 14, 2026

View reviewed changes

Comment thread wolfclu/clu_io.h Outdated

Comment thread src/tools/clu_io.c Outdated

aidankeefe2022 force-pushed the fenrir-11088 branch 2 times, most recently from 423d36d to eae4ffe Compare September 15, 2026 15:24

aidankeefe2022 assigned wolfSSL-Bot and unassigned aidankeefe2022 Sep 15, 2026

aidankeefe2022 added 3 commits October 1, 2026 15:07

added read/write io functions that can be used to interact with any f…

e106516

…ile pointer

harden io untils

2f6d29b

added gaurd to handle valid empty input

a95669f

added more tests for io for base64 and rewrote IO system for base64 looking to extend in the future

Copilot AI balanced review requested due to automatic review settings October 1, 2026 21:48

aidankeefe2022 force-pushed the fenrir-11088 branch from eae4ffe to 4d477ac Compare October 1, 2026 21:48

Copilot started reviewing on behalf of aidankeefe2022 October 1, 2026 21:49 View session

aidankeefe2022 changed the title ~~Fenrir Fix: Base64 stdin input is silently truncated at 8000 bytes~~ New IO utils and Base64 fixes Oct 1, 2026

Copilot AI reviewed Oct 1, 2026

View reviewed changes

Comment thread src/tools/clu_io.c Outdated

Comment thread src/tools/clu_io.c Outdated

Comment thread src/tools/clu_io.c Outdated

Comment thread tests/base64/base64-test.py Outdated

aidankeefe2022 force-pushed the fenrir-11088 branch from 4d477ac to 5520958 Compare October 1, 2026 21:52

fully fleshed out the io system

11f0670

aidankeefe2022 force-pushed the fenrir-11088 branch from 5520958 to 11f0670 Compare October 1, 2026 22:01

aidankeefe2022 mentioned this pull request Oct 2, 2026

Stacked on PR #286: Clu encrypt rework aidankeefe2022/wolfCLU#1

Open

Conversation

aidankeefe2022 commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #286

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #286

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #286

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #286

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #286

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #286

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aidankeefe2022 commented Sep 14, 2026

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #286

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aidankeefe2022 commented Aug 31, 2026 •

edited

Loading