Repository navigation
fix: check only the major version against the Helm Chart - #73
Merged
Merged
Conversation
desaintmartin
force-pushed
the
fix/check-major-version-only
branch
from
October 20, 2026 14:15
f870b85 to
6f78156
Compare
nahuel11500
approved these changes
Oct 20, 2026
nahuel11500
left a comment
nahuel11500
left a comment
Contributor
There was a problem hiding this comment.
LGTM, please adapt the changelog before merging and tagging
desaintmartin
force-pushed
the
fix/check-major-version-only
branch
from
October 20, 2026 14:19
6f78156 to
ccea36c
Compare
A minor or patch release of the package keeps the Helm Chart contract. The check compared major.minor, so a chart upgrade forced a backend upgrade, and a package upgrade forced a chart upgrade. Chartreuse 7.1.0 refuses to start with the Helm Chart appVersion 7.0.0.
desaintmartin
force-pushed
the
fix/check-major-version-only
branch
from
October 20, 2026 14:23
ccea36c to
3c33261
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensure_safe_runcompares the package version with the Helm ChartappVersion(HELM_CHART_APP_VERSION). It comparedmajor.minor:A minor release keeps the Helm Chart contract (environment variables, configuration file). The check now compares the major version only. A different major still aborts.
Follows #72.
Tests