Skip to content

remove stale threshold config for MLS migration - #5557

Open
mastaab wants to merge 2 commits into
developfrom
remove_stale_config
Open

mastaab wants to merge 2 commits into
developfrom
remove_stale_config

Conversation

@mastaab

@mastaab mastaab commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

the configuration options usersThreshold and clientsThreshold of the feature flag mlsMigration where not used since WPB-485 and have been removed from the documentation and helm default values

@mastaab
mastaab requested review from a team as code owners September 24, 2026 10:42
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they should not be moved from these, at least not before verifying that in this version of the backend the mls migration config was already changed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I would consider these frozen and leave them unchanged.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants