Skip to content

fix: show all meeting participants avatars in right order 🍒 [WPB-29001][WPB-28457] - #5320

Closed
saleniuk wants to merge 3 commits into
mainfrom
fix/show-all-meeting-participants-435
Closed

saleniuk wants to merge 3 commits into
mainfrom
fix/show-all-meeting-participants-435

Conversation

@saleniuk

@saleniuk saleniuk commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-29001

Cherry-pick of: #5319


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Meetings do not show all participants, ignoring accounts that don't have image avatar set and should show the generic avatar with initials.

Solutions

Use updated kalium to receive all participants and their data including avatar (if any), name and accent color, to show generic avatar with initials or placeholder if needed. Participants need to be shown in particular order: first creator, then self user and after that all others.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Create a meeting and add someone that doesn't have image avatar.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions

Copy link
Copy Markdown
Contributor

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (main) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

main This PR
d8d8673c9794fa89135c2d060f43fdaecb6bdf65 990a96e7fb42e50617d8a65c49bbb65bbc9b7d30

Is this intentional?

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.86%. Comparing base (cb623d9) to head (5a4a039).

Files with missing lines Patch % Lines
...e/android/feature/meetings/mapper/MeetingMapper.kt 76.92% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5320      +/-   ##
==========================================
+ Coverage   53.82%   53.86%   +0.04%     
==========================================
  Files         755      755              
  Lines       26352    26364      +12     
  Branches     4346     4350       +4     
==========================================
+ Hits        14184    14202      +18     
+ Misses      10792    10784       -8     
- Partials     1376     1378       +2     
Files with missing lines Coverage Δ
...d/feature/meetings/ui/list/MeetingListViewModel.kt 64.38% <100.00%> (+3.18%) ⬆️
...e/android/feature/meetings/mapper/MeetingMapper.kt 87.75% <76.92%> (+13.33%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb623d9...5a4a039. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (main) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

main This PR
d8d8673c9794fa89135c2d060f43fdaecb6bdf65 990a96e7fb42e50617d8a65c49bbb65bbc9b7d30

Is this intentional?

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

  346 files    346 suites   2m 4s ⏱️
2 815 tests 2 815 ✅ 0 💤 0 ❌
2 821 runs  2 821 ✅ 0 💤 0 ❌

Results for commit 5a4a039.

@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk

Copy link
Copy Markdown
Contributor Author

We decided to not hot-fix that one, it's only a visual bug and can be fixed in the next regular release

@saleniuk saleniuk closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant