Change test status race conditions in design of web_extensions.md - #243
Open
justinlulejian wants to merge 1 commit into
Open
Change test status race conditions in design of web_extensions.md#243justinlulejian wants to merge 1 commit into
justinlulejian wants to merge 1 commit into
Conversation
Updated the RFC to mandate that browser.test status listeners are registered before the test extension is loaded. This eliminates test result race conditions caused by cross-browser variations in extension loading speeds, and simplifies browser implementations by removing the need for complex queuing logic.
justinlulejian
changed the title
Author
|
@rdcronin @oliverdunk for initial review |
Author
|
WECG review: @kiaraarose @xeenon @zombie @Rob--W @rdcronin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the RFC to mandate that browser.test status listeners are registered before the test extension is loaded. This eliminates test result race conditions caused by cross-browser variations in extension loading speeds, and simplifies browser implementations by removing the need for complex queuing logic.
We are aware that Safari will need to adjust its implementation to accommodate this change. Safari is currently unable to run WPT tests unless the test status listeners are registered after the extension has loaded. However, we strongly believe that removing the queuing requirement is the best long-term choice for a simpler, improved implementation across all browsers. When designing this system, it is important to consider not only current implementations but also future browsers that want to participate in WPT testing, ensuring their onboarding is as straightforward as possible.