Skip to content

Validate Wave-generated Whale IR with the format-3 reader #862

Closed

Description

@LunaStev

Motivation

Whale PRs wavefnd/Whale#240 and wavefnd/Whale#241 changed cast validation and text identities and added a bounded reader. Wave needs integration coverage for the resolved API, rather than assuming emitted text is readable.

Scope

PR #860 deliberately resolves official master to 020d2a4cf312123518ec75cc865eea1d257c5689. Test emitted modules through parse/verify/print round trips in whale/src/codegen/tests.rs. Later format-4 support is separate work.

Implementation status: Already implemented in open PR #860. This issue restores missing tracking; do not duplicate the implementation. Review and final PR validation remain with that PR.

Completion criteria

  • Verify generated control-flow, call and numeric modules with the pinned reader.
  • Retain ordered conversions and escaped identities through exact text round trips.
  • Keep the dependency on official master and record the tested lockfile revision.

Activity

  1. self-assigned this
    on Oct 7, 2026
  2. added
    enhancementA request for a new feature or improvement.
    ready for reviewThe pull request or issue is ready for review.
    on Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementA request for a new feature or improvement.ready for reviewThe pull request or issue is ready for review.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions