Repository navigation
Baro Bugfixes - #71
Merged
Merged
Conversation
* "leaving soon" notification works again * now becomes locked when becoming unavailable while not checked * now becomes unlocked when becoming available without needing a refresh * v5.3.1
Fixed tasks with cycle schedules that observe DST (only Baro) not showing the correct current offering when they reset when DST is active. * renamed "cycle number" to "reset count" because it doesn't have anything to do with the cycle schedule feature and that's confusing * all daily and weekly tasks are now prepped with a period, not just alternate ref ones * new `fixTimeTravel` function to aid with debugging * removed some error checking for stuff that's checked in tests * added test to validate cycle refs
Collaborator
|
I could have sworn I already merged this. Almost out of the weeds on personal stuff. |
Merged
1 of 2 tasks
HelpfulSoft1207
added a commit
that referenced
this pull request
Oct 12, 2026
…consistent coding style (#69) <!-- Do not delete this section --> **AI Disclosure:** <!-- Mark *one* box by putting an 'x' between the brackets, like this: [ ] -> [x] --> - [x] I **did not** use AI for anything in this pull request. - [ ] I *did* use AI in this pull request, and I have included a statement of AI use in the commit message of *every* commit where I used AI. <!-- ↓↓↓ Add any other information about your use of AI that you wish to include here ↓↓↓ --> _____ <!-- ↓↓↓ Write the rest of your pull request below this line ↓↓↓ --> [ESLint](https://eslint.org/) and [Stylelint](https://stylelint.io/) are static code analysis tools that can catch common JavaScript and CSS problems and enforce a consistent coding style. I propose that we adopt them for this project. ## Proposed Coding Style ### JavaScript * [Indent](https://eslint.style/rules/indent) with 4 spaces. * Require [semicolons](https://eslint.style/rules/semi). * Use [double quotes](https://eslint.style/rules/quotes), unless single quotes would allow for fewer escape sequences. * Single-parameter arrow functions must [always use parentheses](https://eslint.style/rules/arrow-parens). * Single-statement blocks [must use braces](https://eslint.org/docs/latest/rules/curly). * Use the ["*one true brace style*"](https://eslint.style/rules/brace-style). * The exception to this is when an `if` and `else` block each have exactly one statement. Unfortunately, the eslint rule doesn't seem to support this. I could maybe write my own, but that seems like a bunch of extra work for not a lot of benefit. Just use `/* eslint-disable-line @stylistic/brace-style */` for these cases. * Multiline arrays and object literals [must have a trailing comma](https://eslint.style/rules/comma-dangle#always-multiline). * Curly braces must have spaces on their inner face (for [blocks](https://eslint.style/rules/block-spacing) and [objects](https://eslint.style/rules/object-curly-spacing), unless the object is empty). There are many other rules active from the recommended configuration, but most of them are fairly obvious or have little-to-no effect on our codebase because we're already following them or don't use those language features. ### CSS The Stylelint config is largely comparable to the ESLint one, with some notable rules specific to CSS: * Use [modern color function notation](https://stylelint.io/user-guide/rules/color-function-notation). * Use [percentages for alpha values](https://stylelint.io/user-guide/rules/alpha-value-notation). * Use `s` (seconds) instead of `ms` (milliseconds) for time units. ### JSON * Use the [recommended](https://github.com/eslint/json#rules) JSON configuration. ## Integration * A new **GitHub Actions workflow** will automatically run the checks on push and on pull request, much like we already have for Vitest. * You can install the provided **pre-commit hook** to do it for you locally ([see note](#69 (comment))). The pre-commit hook will also run the existing Vitest suite. * **Run manually:** * ESLint: `npm run lint:js` * Stylelint: `npm run lint:css` * Both: `npm run lint` (Stylelint will only run if there are no ESLint errors). * **Editor extensions** are available to highlight problems directly in your editor: * | | VS Code | Other VSIX editors<br>(e.g. vscodium) | |-:|:-------:|:-------------------------------------:| | **ESLint** | [from VS Marketplace](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint) | [from Open VSX](https://open-vsx.org/extension/dbaeumer/vscode-eslint) | | **Stylelint** | [from VS Marketplace](https://marketplace.visualstudio.com/items?itemName=stylelint.vscode-stylelint) | [from Open VSX](https://open-vsx.org/extension/stylelint/vscode-stylelint) | ## ~~Bug Fixes~~ * ~~Baro's "leaving soon" notification works again (caught by ESLint).~~ Merged in #71 * ~~Bump version to 5.3.1~~ No version bump because there are no longer any user-visible changes. This PR remains at v5.3.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Disclosure:
Here's the bugfixes factored out of #69 as discussed. You can merge either this or #69 first, and I'll fix the resulting merge conflicts with the other one.
Bug Fixes
Code Stuff
period, not just alternaterefones.fixTimeTravelfunction to aid with debugging.refs.