Repository navigation
Remove the automotive likeness check and publish gate - #1113
Merged
Merged
Conversation
Drop verify check body-likeness, design_loop likenessProfile/bodyLikeness, reference.likeness.* diagnostics, the likeness module, the car gate skill text and the roadster dynamics test.
…sign_loop skill wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of trimming overfit tooling: a check and gate hard-coded to one object class (cars).
Removed:
verify({ check: 'body-likeness' })and its car-only inputs (body_bbox,body_feature_id,cabin_bbox,wheels,length_axis,still_verdicts,require_stills);checkBodyLikeness.ts.src/agent/likeness/(bodyLikeness.ts,publishGate.ts— the gate string-matched product names like "berlinetta" in the source).design_looplikenessProfile: 'automotive'andbodyLikeness, and the car still codes it added to the required visual checks.reference.likeness.{auto-failed,stills-incomplete,still-failed}.src/dynamics/roadster.test.ts(the only src test wired to an example); unused allow-list entries indistToolNameGate.ts.Kept: the generic
visualReview.checksmechanism, the surfacing advice, and the car cookbook snippets /examples/roadsteras plain modelling examples (gate calls and product keywords removed).MCP contract:
verifyloses thebody-likenessenum value and its properties;design_looploses two inputs. Tool order unchanged.Local verification (Node 22, merged with develop after #1112): typecheck, qc:lint (0 errors), skills/cheat-sheet drift clean, 1145 targeted tests (MCP tools/registry, diagnostics, distGenerate, cookbook, design_loop). Full suite runs in CI.