Repository navigation
run fixture: nx on its current major, report the version that ran - #226
Merged
Merged
Conversation
The `run` fixture pinned nx@20.3.1 while setup.sh installs nx@latest (24.x). A global nx hands off to the project's copy, so `run` timed nx 20 and versions.json said 24.0.6. Move the fixture to nx@^24 (how Nx recommends installing it, and the default experience), and make setup.sh report the version the fixture's nx and turbo ranges resolve to instead of the global `@latest`, so versions.json names the version that ran. METHODOLOGY said the fixture "has no dependencies"; it has nx and turbo as devDependencies, which every tool's prepare installs. Say what it contains and that the task runners run from the fixture's own install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the 2026-11-18 audit, finding F4.
The problem
suite/fixtures/run/package.jsonhadnx@20.3.1andturbo@^2.3.3as devDependencies. Every tool's prepare installs them, and the global nx 24 (setup.sh,nx@latest) hands off to the project's copy. Soruntimed nx 20.3.1 whileversions.jsonreported nx 24.0.6 (two majors off).docs/METHODOLOGY.mdalso said the fixture "has no dependencies", whichdocs/FIXTURES/RUN.mdalready contradicted.The fix
nx@^24.0.6(latest 24.x today is 24.0.6, the same versionnx@latestresolves to). A local nx is kept: that is how Nx recommends installing it, and it is the default experience. turbo stays^2.3.3, which already resolves to the latest 2.x (2.11.12 today, same asturbo@latest).versions.jsonnames the version that ran.setup.shnow reports, fornxandturbo, the version the fixture's range resolves to (npm view <tool>@<range> version, highest match) instead of<tool>@latest. Both resolve against the registry at setup time, like before; the difference is only visible when the latest release is on a new major the fixture range doesn't cover. The consumers (apps/data,apps/www) readversions.jsonby tool name and need no change.runsection now says what the fixture contains (one echo script,nxandturboon their current majors), that every prepare installs it (about 130 packages) and thatnxandturborun from the fixture's ownnode_modules, and when the global and the reported version can differ.docs/FIXTURES/RUN.mdnames the two devDependencies.Verified
/home,HOME=/home/runner,/home/lukeabsent, nonpm_config_*/XDG_*/DENO_DIR; node 26 and the tools assetup.shleaves them):./bench run --fixtures=run --variation=run --pms=npm,nx,turbo,nodewith 1 warmup, 3 runs. All exit codes 0. Throughout the run the fixture'snode_modules/nx/package.jsonwas24.0.6andnode_modules/turbo/package.json2.11.12(polled every 0.2 s), and the nx processes in the timed window weresuite/fixtures/run/node_modules/nx/dist/bin/run-executor.jsplus three plugin workers from the same folder, i.e. the fixture's nx 24, not the global one.setup.shresolver:nx→24.0.6,turbo→2.11.12; an exact spec (one match, a JSON string) also works.node --test suite/scripts/45/45;vlr format:check,vlr lint:check,vlr test(318 passed) from the root.vlt-lock.jsonnot committed.🤖 Generated with Claude Code