Skip to content

run fixture: nx on its current major, report the version that ran - #226

Merged
lukekarrys merged 1 commit into
mainfrom
lk/run-fixture-nx24
Nov 18, 2026
Merged

lukekarrys merged 1 commit into
mainfrom
lk/run-fixture-nx24

Conversation

@lukekarrys

Copy link
Copy Markdown
Member

From the 2026-11-18 audit, finding F4.

The problem

suite/fixtures/run/package.json had nx@20.3.1 and turbo@^2.3.3 as devDependencies. Every tool's prepare installs them, and the global nx 24 (setup.sh, nx@latest) hands off to the project's copy. So run timed nx 20.3.1 while versions.json reported nx 24.0.6 (two majors off). docs/METHODOLOGY.md also said the fixture "has no dependencies", which docs/FIXTURES/RUN.md already contradicted.

The fix

  • Fixture: nx@^24.0.6 (latest 24.x today is 24.0.6, the same version nx@latest resolves to). A local nx is kept: that is how Nx recommends installing it, and it is the default experience. turbo stays ^2.3.3, which already resolves to the latest 2.x (2.11.12 today, same as turbo@latest).
  • versions.json names the version that ran. setup.sh now reports, for nx and turbo, the version the fixture's range resolves to (npm view <tool>@<range> version, highest match) instead of <tool>@latest. Both resolve against the registry at setup time, like before; the difference is only visible when the latest release is on a new major the fixture range doesn't cover. The consumers (apps/data, apps/www) read versions.json by tool name and need no change.
  • METHODOLOGY: the run section now says what the fixture contains (one echo script, nx and turbo on their current majors), that every prepare installs it (about 130 packages) and that nx and turbo run from the fixture's own node_modules, and when the global and the reported version can differ. docs/FIXTURES/RUN.md names the two devDependencies.

Verified

  • Sandbox (user+mount namespace, tmpfs on /home, HOME=/home/runner, /home/luke absent, no npm_config_*/XDG_*/DENO_DIR; node 26 and the tools as setup.sh leaves them): ./bench run --fixtures=run --variation=run --pms=npm,nx,turbo,node with 1 warmup, 3 runs. All exit codes 0. Throughout the run the fixture's node_modules/nx/package.json was 24.0.6 and node_modules/turbo/package.json 2.11.12 (polled every 0.2 s), and the nx processes in the timed window were suite/fixtures/run/node_modules/nx/dist/bin/run-executor.js plus three plugin workers from the same folder, i.e. the fixture's nx 24, not the global one.
  • The new setup.sh resolver: nx → 24.0.6, turbo → 2.11.12; an exact spec (one match, a JSON string) also works.
  • node --test suite/scripts/ 45/45; vlr format:check, vlr lint:check, vlr test (318 passed) from the root. vlt-lock.json not committed.

🤖 Generated with Claude Code

The `run` fixture pinned nx@20.3.1 while setup.sh installs nx@latest (24.x).
A global nx hands off to the project's copy, so `run` timed nx 20 and
versions.json said 24.0.6. Move the fixture to nx@^24 (how Nx recommends
installing it, and the default experience), and make setup.sh report the
version the fixture's nx and turbo ranges resolve to instead of the global
`@latest`, so versions.json names the version that ran.

METHODOLOGY said the fixture "has no dependencies"; it has nx and turbo as
devDependencies, which every tool's prepare installs. Say what it contains
and that the task runners run from the fixture's own install.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
benchmarks Ready Ready Preview Nov 18, 2026 9:14am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: acd72a4c-f0fa-4c0f-8fc9-67f836f68cf5
Commits

Reviewing files that changed from the base of the PR and between 0b3a2dc and 43fe4f9.

Files selected for processing: 4

  • docs/FIXTURES/RUN.md
  • docs/METHODOLOGY.md
  • suite/fixtures/run/package.json
  • suite/scripts/setup.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@lukekarrys
lukekarrys merged commit eb8bc4b into main Nov 18, 2026
78 checks passed
@lukekarrys
lukekarrys deleted the lk/run-fixture-nx24 branch November 18, 2026 09:36

This branch was previously deployed

1 inactive deployment
Benchmark — 43fe4f9b Deployed Nov 18, 2026 by lukekarrys via Run Benchmarks (build, next) #1469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant