Repository navigation
fix(process-count): lockfile, node_modules and cache variations count each tool from its own state #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(process-count): lockfile, node_modules and cache variations count each tool from its own state #218
Changes from all commits
a5490a3
278cec4
04a4ee3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -167,7 +167,7 @@ ci_setup_prepare() { | |
| fi | ||
|
|
||
| # Generate lockfile via regular install | ||
| result="$result; $install_cmd >/dev/null 2>&1 || true" | ||
| result="$result; timeout $BENCH_TIMEOUT $install_cmd >/dev/null 2>&1 || true" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Propagate a failed warmup into the process-count prepare.
Make a failed warmup give a nonzero status to the process-count prepare. Complete the cleanup, uninstall, and cache purge steps first. Use the same pattern as
|
||
|
|
||
| # Clean node_modules (ci starts fresh) | ||
| result="$result; $BENCH_CLEAN_POST" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -74,7 +74,7 @@ ci_prepare() { | |
| if [ -n "$setup_cmd" ]; then | ||
| result="$result; $setup_cmd" | ||
| fi | ||
| result="$result; $install_cmd >/dev/null 2>&1 || true; $BENCH_CLEAN_POST" | ||
| result="$result; timeout $BENCH_TIMEOUT $install_cmd >/dev/null 2>&1 || true; $BENCH_CLEAN_POST" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Propagate the warmup failure status before counting. The Required behavior: when the lockfile-generating install exits nonzero, including timeout exit codes 124 and 137, the counting prepare must exit with that status after
|
||
| echo "$result" | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Limit the setup-failure guarantee to prepares that propagate failure.
ci_prepareandci_setup_preparestill generatetimeout ... || true. If the warmup fails after creating a lockfile, later cleanup can return success.process-count.shthen runs the counted install and can record its result.Limit this statement to the prepares that propagate warmup failure. Alternatively, make the CI prepares preserve that failure through their required cleanup.