Repository navigation
fix: give every tool babylon's manifests as committed - #213
Conversation
add-workspace-protocol.js rewrote babylon's plain sibling ranges to `workspace:*`, in vlt's setup only. vlt 1.8 does that rewrite itself on install (--migrate-workspaces is on by default), so the script now only handed vlt an adjusted project. Drop it; clean_workspace_protocol still restores the manifests vlt migrates. pnpm's registry lookups for siblings are its own default: with plain ranges it queries the registry for each one (240 lookups cold, 223 of them 404) before linking it, and with `workspace:*` it makes none. linkWorkspacePackages is read by pnpm 12. METHODOLOGY now says how each tool handles babylon's siblings. Fixes #210 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 18 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Review: the code is right; fix the docs, and decide on one vlt behaviour firstThe change itself is correct and minimal. Removing Decide before merging: vlt's sibling resolution on babylon flips between two statesWith the manifests as committed, vlt 1.8.0's migration rewrites 257 of the 323 sibling specs. The 66 it leaves alone are exact and peer specs on the published
This looks like a vlt bug (incomplete migration plus nondeterministic resolution), not a problem with this PR. But with this PR, vlt's published Fix: docs and PR text
Nits
Verified
🤖 Reviewed with Claude Code |
vlt 1.8.0 rewrites 257 of babylon's 323 sibling specs; the 66 exact/peer specs on @babylonjs/* stay as-is, and about half of cold installs resolve four of them to registry copies. Only `clean` times the migration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…225) Since #213 every tool installs babylon's manifests as committed: plain semver sibling ranges, which vlt 1.8.0 rewrites to `workspace:*` on its first install. A vlt user's repo stays migrated after that install, so in every variation but `clean`, vlt's --prepare now runs `migrate_workspace_protocol` (clean-helpers.sh) before its first install of a set: `vlt install --lockfile-only --view=silent`, which rewrites the manifests with no node_modules and no tarballs; the lockfile it writes is discarded, or a pre-existing one is restored byte for byte. Later prepares find `workspace:` present and do nothing; clean_all undoes it between tools. `clean` sets BENCH_SETUP_VLT empty, so the migration stays part of the timed first install there. If --lockfile-only fails, the helper warns and vlt's first install migrates as before. METHODOLOGY documents where the migration happens and that it does not make vlt's first warm babylon run like the later ones: vltpkg/vltpkg#2155 (optional `canvas` written to the lockfile but not installed on a first install) means vlt installs 1,601 packages instead of 1,618 in the no-lockfile variations, which slightly flatters vlt, and the first install from a lockfile downloads those 17. No workaround in the suite. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Fixes #210 (babylon: only vlt gets
workspace:*manifests).What changed
suite/scripts/add-workspace-protocol.jsand emptiedBENCH_SETUP_VLT. Every tool now installsbabylonexactly as committed.clean_workspace_protocolstays, with a new comment: it now undoes vlt's own manifest rewrite between tools.FIXTURES/BABYLON.mdsay how each tool links babylon's siblings.Answers to the issue's questions
Does vlt still need the rewrite? No. vlt 1.8.0 migrates plain sibling ranges to
workspace:*itself on install: 80package.jsonfiles onbabylon, 257 of the 323 sibling specs. A second install on the migrated manifests changes nothing. Correction (see the review): vlt 1.8.0 leaves the 66 exact and peer specs on the published@babylonjs/*names as they are, and in about half of cold installs resolves four of them to registry copies instead of the workspace (install: workspace migration skips exact/peer specs on published workspace names, and they resolve to registry copies in ~half of cold installs vltpkg#2154). METHODOLOGY now says so.Rewrite for every tool? Not needed once no tool gets it.
Why does pnpm look up siblings? pnpm 12 does read
linkWorkspacePackages: trueand links the siblings (295link:entries in the lockfile). It still asks the registry about each plain-range sibling first. Cold, behind a logging proxy:workspace:*pnpm also installs
@babylonjs/shared-ui-componentsfrom the registry, because it is a peer dependency ofsmartFiltersEditorControl. The audit'sprobe-wsfailure was a probe whosepnpm-workspace.yamllackedlinkWorkspacePackages: true. With one that setslinkWorkspacePackages: true, as babylon has, pnpm installs it.Every tool, vlt included now, downloads
babylonjs-gltf2interface@6from the registry.packages/tools/devHostasks for^6.42.0and the workspace has 8.49.6, so the registry is the correct source.Expected change in published
babylonnumbersOnly vlt's numbers should move:
clean;registry-*uses npm as the client), vlt's timed run now includes writing the 80package.jsonfiles.babylonjs-gltf2interface@6.The other tools already got the committed manifests, so their inputs don't change. pnpm's ~240 sibling lookups remain: they are its default behaviour.
Testing
suite/scripts/*.test.js): 24 pass. oxfmt is clean.babylonjs-gltf2interface; in the rest it also downloads four@babylonjs/*siblings (install: workspace migration skips exact/peer specs on published workspace names, and they resolve to registry copies in ~half of cold installs vltpkg#2154).workspace:*(table above).cleanandadd-overlapfor every tool.🤖 Generated with Claude Code