Repository navigation
Quick fixes from the benchmark audit: zpm/berry caches, vlt children, ci+setup, Yarn 1 counts #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Sourced by clean-helpers.sh and add-remove-state.sh. | ||
| # | ||
| # vlt finishes work in detached child processes that outlive the vlt command. | ||
| # vlt 1.8.0 has five, each a `node .../vlt/<name>-src-<name>.js` script: | ||
| # | ||
| # cache-unzip-src-unzip.js unpacks fetched tarballs into the | ||
| # cache (renames itself vlt-cache-unzip) | ||
| # registry-client-src-revalidate.js revalidates cached manifests | ||
| # (vlt-cache-revalidate) | ||
| # rollback-remove-src-remove.js deletes node_modules/.vlt/.VLT.DELETE.* | ||
| # (keeps its command line) | ||
| # security-archive-src-update-expired.js (vlt-security-archive-update) | ||
| # cli-sdk-src-update-check.js (vlt-update-check) | ||
| # | ||
| # Match the renamed ones by process name (Linux truncates it to 15 | ||
| # characters, e.g. "vlt-cache-reval", so match the vlt- prefix), and every one | ||
| # by its original command line, which covers rollback-remove and the moment | ||
| # before a child renames itself. Matching the name, not the command line, for | ||
| # the first check means a shell whose arguments mention these names can never | ||
| # match itself; the [.] does the same for the second. | ||
| vlt_background_running() { | ||
| pgrep -u "$(id -u)" '^vlt-' >/dev/null || | ||
| pgrep -u "$(id -u)" -f '/vlt/[a-z-]+-src-[a-z-]+[.]js' >/dev/null | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stub Corepack in the Berry cache tests.
Only
safe_removeis replaced. When Corepack is installed, the Berry assertions still runcorepack yarn@latest cache clean --allfromclean_berry_cache. Yarn performs those removals internally, so the test log does not record them. With an inheritedYARN_GLOBAL_FOLDER, the command can delete the developer's real global Yarn cache despite the dummyHOME.Add a no-op
corepackexecutable to the temporarybindirectory thatremovedByprepends toPATH. The directory must be created before the test runs. Keep the existing path assertions.