Skip to content

Trello: invite a Product Owner without a Trello account as a normal member - #124

Merged
Delmar-Ramcic merged 1 commit into
mainfrom
fix/trello-admin-without-account
Nov 12, 2026
Merged

Delmar-Ramcic merged 1 commit into
mainfrom
fix/trello-admin-without-account

Conversation

@Oceandek

Copy link
Copy Markdown
Collaborator

Fixes the "Trello refused: Bad member type" the team got for every Project when pressing Check members (2026-11-12).

Cause

Trello refuses to make an email address without a Trello account an admin of a board. It answers 403 Bad member type, both on the invitation (PUT /boards/{id}/members?type=admin) and on a later promotion (PUT /boards/{id}/members/{member}?type=admin). The platform invites every Product Owner as admin, so every Project whose Product Owner has no Trello account yet failed (here: the dummy teacher addresses). The real try in October passed because that Product Owner already had an account.

Confirmed on the old test board "PmpRealTest 0923" with a team address: invite as admin gave 403 Bad member type, invite as normal gave 200, promoting the unconfirmed member to admin gave 403. The probe member was removed afterwards and the board is unchanged.

Fix

  • HttpTrello.invite: on "Bad member type" for an admin invitation, invite as normal instead. Any other refusal, or the same one for a normal invitation, still fails.
  • Check members: a member who is still unconfirmed (no Trello account yet) isn't promoted. A later Check members makes them admin once they've signed up and accepted.
  • FakeTrello behaves like Trello: no admin without an account, and set_member_type to admin on an unconfirmed member raises.

Tests

  • Backend: 411 passed.
    • New test_trello_client.py tests the real client with httpx.MockTransport: the fallback to normal, and other refusals still failing.
    • New tests: a Product Owner without Trello is invited as normal, Check members doesn't fail, and they become admin after signing up; a Product Owner with Trello is invited as admin directly.
    • The old expectation "Product Owner without an account invited as admin" was updated.
  • Frontend Trello tests: 6 passed.

After the deploy: press Check members for all Projects again.

🤖 Generated with Claude Code

…ember

Trello refuses "admin" for an email without a Trello account (403 "Bad member
type", seen 2026-11-12 on every Project with a dummy Product Owner), so Check
members failed. HttpTrello.invite now falls back to "normal", and Check members
only makes them admin once they have an account and accepted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Delmar-Ramcic
Delmar-Ramcic merged commit 6f21257 into main Nov 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants