Repository navigation
Add .nvmrc, and say what odd Node releases do - #3
Merged
Merged
Conversation
`engines` said 22.13 or later, so Node 25 looked fine until vitest's own range refused it at install. It now matches: 22.13+, 24, or 26 and up. web/.nvmrc lets fnm and nvm pick 26 on their own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nvm refuses a version that isn't installed, and 26 only became LTS last week; any 24.x satisfies `24`. Both pass the checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Docent runs on any Node from 22.13; only the test tools refuse odd-numbered releases. engines goes back to >=22.13, and the README says what npm install does on those releases instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vivecuervo7
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
web/.nvmrcwith24, fornvm useand fnm's automatic switching.enginesstays>=22.13, what Docent itself needs for the built-in SQLite.Why
Someone on Node 25 had
npm installstop withEBADENGINE: vitest 5 doesn't support odd-numbered releases, and with npm'sengine-stricton that's an error rather than a warning. Docent itself runs on 25; only the test tools refuse it. They asked for an.nvmrc, so fnm switches to a version that installs cleanly..nvmrcholds a single major version, and nvm refuses one that isn't installed.24(any 24.x) works for more people today than 26, which only became LTS on 28 October.🤖 Generated with Claude Code