Skip to content

fix(rsc): make unknown server references fail with a recognizable error #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agcty wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

fix(rsc): make unknown server references fail with a recognizable error #1472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/plugin-rsc/src/rsc/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,15 @@ setRequireModule({
)
return import(/* @vite-ignore */ id)
} else {
const import_ = serverReferences[id]
// own keys only: an id such as `__proto__` must not resolve to an
// inherited member of the registry object
const import_ = Object.hasOwn(serverReferences, id)
? serverReferences[id]
: undefined
if (!import_) {
throw new Error(`server reference not found '${id}'`)
throw Object.assign(new Error(`server reference not found '${id}'`), {
code: 'VITE_RSC_SERVER_REFERENCE_NOT_FOUND',
})
}
return import_()
}
Expand Down
Loading