Repository navigation
chore: sync develop with 4.x - #160
Open
thetutlage wants to merge 97 commits into
Open
thetutlage wants to merge 97 commits into
thetutlage wants to merge 97 commits into
Conversation
Removes the need of creating separate VineObject and then wrap it inside the compiler
…n a string with multiple empty spaces Closes: #138
Replace the positional join('_') key in helpers.isDistinct with
JSON.stringify so the field position and value type are preserved.
A join based key collapses distinct inputs to the same string:
['a_b', 'c'] and ['a', 'b_c'] both become 'a_b_c', and the number 1
and string '1' both become '1'. Both cases produced false duplicate
errors. Add tests covering these collisions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
developto parity with4.x.developis 97 commits behind4.xand has no commits of its own, so this is a pure fast-forward with no conflicts. It includes the 4.3.0, 4.3.1 and 4.4.0 releases, plus everything merged into4.xsince then, up to #158 (synchronous validation).Note: GitHub's "Rebase and merge" rewrites commit SHAs, and "Squash" collapses the history. Use "Create a merge commit" to keep the
4.xSHAs, or fast-forward from the CLI withgit push origin origin/4.x:developfor exact parity.🤖 Generated with Claude Code