Repository navigation
perf: avoid array allocations for single-field distinct checks - #156
Open
RomainLanz wants to merge 2 commits into
Open
RomainLanz wants to merge 2 commits into
RomainLanz wants to merge 2 commits into
Conversation
Restore wrapping non-array fields in an array so JavaScript callers passing a numeric field no longer crash with "keys is not iterable". Also cover null handling for composite distinct fields, which lost coverage after single fields moved to a dedicated path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
distinct('field')created and traversed a temporary values array for every item, even though it only needed one value.This change adds a dedicated single-field path that reads the value directly. It keeps
JSON.stringify([value]), so null handling, value types, objects, and serialization behavior remain unchanged. Composite distinct checks are not modified.Benchmark
Measured on Node.js 24.21.0 with compiled validators reused across validations. The workload validates arrays of 256 objects with one distinct scalar field.
Checks
npm test, 1,135 passed and 1 todonpm run typecheck