Repository navigation
feat(report): keep advisory corpus metadata in a collapsed HTML footer - #449
Draft
vibgrate-team wants to merge 1 commit into
Draft
vibgrate-team wants to merge 1 commit into
vibgrate-team wants to merge 1 commit into
Conversation
vg report --format html left #advisory-corpus empty, so vulnerability database provenance never appeared. The footer now records extended.vulnerabilities source, advisory and package counts, and severity counts after the finding tables, collapsed so those tables stay first. An unreachable source does not print zero counts, and the same artifact still produces the same HTML. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vg report --format htmlreserved#advisory-corpusas an empty hidden mount, so advisory-database provenance never appeared on the page. Putting that metadata in a top banner would push the summary and finding tables down.The page now fills that mount with a collapsed
<details>footer after the vulnerability, security, and other-finding tables. It reads fields already stored onextended.vulnerabilities:source—osv(online OSV),manifest(offline package-version manifest),unreachable, ornonetotalAdvisoriespackagesare listedseverityCounts, always in the order critical, high, moderate, low, unknownThe scan artifact does not store a separate advisory-corpus version.
sourceis the recorded database provenance. A missing vulnerability block says "Not scanned".source: "unreachable"records the source and does not print zero counts. Strings are redacted and escaped like the rest of the page. The same artifact still produces the same HTML: no clock, no randomness, and severity counts do not follow object key order.DOCS.md and the README note that this provenance lives in the collapsed
#advisory-corpusfooter.Related issues
Closes #245
How to verify
pnpm test pnpm lint pnpm typecheckpnpm test(5240 passed),pnpm lint(no new issues), andpnpm typecheckpassed.src/reporting/formatters/html.test.tsasserts footer content, field order, placement after the finding tables, collapsed markup, escaping, and byte-stable output when package order or severity key order changes.Checklist
pnpm testpassespnpm lintis cleanpnpm typecheckis cleangraph.json/ report output (content-hashed IDs, stable sorts; no time, randomness, or filesystem-order dependence)git commit -s, DCO)Notes for reviewers
The footer stays collapsed (no
openattribute) and has no banner styling, so the summary and tables remain first. Package names and advisory ids stay in the tables; the footer only carries the source and the counts.