Repository navigation
feat(report): add a fix-available-only filter to HTML reports - #447
Draft
vibgrate-team wants to merge 3 commits into
Draft
vibgrate-team wants to merge 3 commits into
vibgrate-team wants to merge 3 commits into
Conversation
vg report --format html now includes an unchecked "Fix available only" checkbox. Checking it hides rows whose data-fix-available attribute is "no", using fixed versions already stored on the scan artifact. The generated page stays byte-stable, still contains every row, and does not call a registry or embed a script. Closes #249 Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
…able-filter-adcb Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
The HTML summary includes an unchecked Fix available only checkbox. Checking it hides rows that do not name a fixed version. The page file still contains every finding, and the summary counts stay complete. Closes #249 Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vg report --format htmlshowed every finding, so long pages buried the rows that already name a fixed version. Each row was already stampeddata-fix-available="yes"or"no"fromdetails.fixedVersionson the scan artifact, but the page had no control to show only the rows with a known fix.The summary now includes an unchecked Fix available only checkbox. Checking it hides table rows whose
data-fix-availableattribute isno. The generated HTML still contains every row, so a fixed artifact stays byte-stable and the default view is unchanged. The filter is a style rule in the page: no script, no external assets, and no registry call at report time. Summary counts stay complete.Related issues
Closes #249
How to verify
pnpm test,pnpm lint, andpnpm typecheck.pnpm dev report --in .vibgrate/scan_result.json --format html > report.html.report.html. Every finding is visible. Check Fix available only and confirm rows without a known fix disappear. Uncheck it and confirm they return. The file on disk does not change.Unchecked, every row is on the page:
HTML report with the fix-available-only checkbox unchecked and every row visible
Checked, rows with no known fix are hidden. The summary count stays
Fix available: 2:HTML report filtered to rows that name a known fix
html-fix-available-only-filter.mp4
Checklist
pnpm testpassespnpm lintis cleanpnpm typecheckis cleangraph.json/ report output (content-hashed IDs, stable sorts; no time, randomness, or filesystem-order dependence)git commit -s, DCO)Notes for reviewers
The control is CSS (
body:has(#fix-available-only:checked) tr[data-fix-available="no"]), so the page still has no embedded script. A row isyesonly when the existing fix hint finds a non-emptydetails.fixedVersionslist already on the artifact. Security findings staydata-fix-available="no"and hide while the box is checked.To show artifacts inline, enable in settings.