fix: abort the connection when a handler throws after the response started - #493
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an unhandled promise rejection when a handler throws after it has already started writing the response.
Problem
sendError()always callssend(), which setsContent-Length. If the handler already calledres.write(), the headers are sent andsetHeader()throwsERR_HTTP_HEADERS_SENT. The throw happens inside thecatchofrun(), so the promise fromrun()rejects with nothing to handle it. On current Node.js versions an unhandled rejection terminates the process.Changes
sendError()checksres.headersSent. When the headers are already sent, it can't send an error response, so it destroys the connection unless the response has ended. The client sees a failed request instead of a truncated body that looks complete.res.write()and asserts thatrun()resolves.Testing
Before the change, the new test fails with
ERR_HTTP_HEADERS_SENTreported as an unhandled rejection. After the change, all three suites pass.