Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
feugy
force-pushed
the
damienfeugas/exp-3435-custom-waituntil
branch
from
September 11, 2026 06:53
bef5ec7 to
da74a8e
Compare
feugy
force-pushed
the
damienfeugas/exp-3435-custom-waituntil
branch
from
September 11, 2026 15:10
da74a8e to
6e38425
Compare
feugy
force-pushed
the
damienfeugas/exp-3435-custom-waituntil
branch
from
September 11, 2026 15:31
6e38425 to
690efd3
Compare
AndyBitz
approved these changes
Sep 11, 2026
dferber90
requested changes
Sep 15, 2026
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🖖 What's in there?
Allows
createClientcallers to provide a customwaitUntilfunction for background usage and experiment exposure reporting. The default export continues to use@vercel/functions; the Next.js conditional export now defaults toafterfromnext/server. An explicit option always wins.Evaluation stays non-blocking. On long-lived or self-hosted processes,
client.shutdown()drains pending exposure reports during graceful shutdown.Fixes EXP-3435.
🤺 How to test?
pnpm testinpackages/vercel-flags-core.pnpm type-checkinpackages/vercel-flags-core.pnpm buildinpackages/vercel-flags-core.afteras the default lifecycle function.waitUntiland verify it overrides the entry-point default for usage and exposure reporting.client.shutdown()waits for that reporting to finish.🔬 Notes to reviewers
The public type is
(promise: Promise<unknown>) => void, matching@vercel/functionsand common worker runtime APIs.This provides non-blocking reporting with lifecycle registration, plus deterministic draining during graceful shutdown. It cannot guarantee delivery after abrupt process termination or permanent network failure; that requires durable storage.
🔗 Related PRs