Repository navigation
Add CI functionality - #186
Open
OAharoni-RedHat wants to merge 5 commits into
Open
Add CI functionality #186OAharoni-RedHat wants to merge 5 commits into
OAharoni-RedHat wants to merge 5 commits into
Conversation
These are needed by the new CI system
OAharoni-RedHat
force-pushed
the
add-singleArgoCD
branch
from
October 21, 2026 20:46
0ef5cd2 to
a6d57fb
Compare
mlorenzofr
requested changes
Oct 22, 2026
mlorenzofr
left a comment
mlorenzofr
left a comment
Collaborator
There was a problem hiding this comment.
Overall, the changes are correct. Just a few minor adjustments are needed to align them with other changes in the main branch.
| namespace: quay-enterprise | ||
| argoProject: hub | ||
| chart: quay | ||
| chartVersion: 0.1.* |
Collaborator
There was a problem hiding this comment.
We have recently migrated this chart to version 0.2.*
Suggested change
| chartVersion: 0.1.* | |
| chartVersion: 0.2.* |
Comment on lines
+85
to
+89
| overrides: | ||
| - name: job.image | ||
| value: "registry.redhat.io/openshift4/ose-cli-rhel9:latest" | ||
| - name: job.resources.limits.memory | ||
| value: "512Mi" |
Collaborator
There was a problem hiding this comment.
We changed this in #184
Suggested change
| overrides: | |
| - name: job.image | |
| value: "registry.redhat.io/openshift4/ose-cli-rhel9:latest" | |
| - name: job.resources.limits.memory | |
| value: "512Mi" | |
| extraValueFiles: | |
| - /overrides/values-quay.yaml |
Comment on lines
+159
to
+160
| - name: quay.enabled | ||
| value: "true" |
Collaborator
There was a problem hiding this comment.
Deprecated option for quay-chart 0.2.*
Suggested change
| - name: quay.enabled | |
| value: "true" |
| subscriptions: | ||
| openshift-pipelines: | ||
| name: openshift-pipelines-operator-rh | ||
| namespace: openshift-operators |
Collaborator
There was a problem hiding this comment.
Suggested change
| namespace: openshift-operators | |
| namespace: openshift-operators | |
| channel: pipelines-1.23 |
Comment on lines
+9
to
+11
| user: quay-user | ||
| vaultPath: "secret/data/hub/infra/quay/quay-users" | ||
| passwordVaultKey: "quay-user-password" |
Collaborator
There was a problem hiding this comment.
If using the file overrides/values-quay.yaml:
Suggested change
| user: quay-user | |
| vaultPath: "secret/data/hub/infra/quay/quay-users" | |
| passwordVaultKey: "quay-user-password" | |
| user: quay-admin | |
| vaultPath: "secret/data/hub/infra/quay/quay-users" | |
| passwordVaultKey: "quay-admin-password" |
| .PHONY: install | ||
| #install: pattern-install ## Installs the pattern onto a cluster (Loads secrets as well if configured) | ||
| install: operator-deploy load-secrets | ||
| install: pattern-install ## Installs the pattern onto a cluster (Loads secrets as well if configured) |
Collaborator
There was a problem hiding this comment.
We had discussed this with @day0hero at #123. We prefer bypassing Argo CD validation.
Suggested change
| install: pattern-install ## Installs the pattern onto a cluster (Loads secrets as well if configured) | |
| #install: pattern-install ## Installs the pattern onto a cluster (Loads secrets as well if configured) | |
| install: operator-deploy load-secrets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include new CI Folder and override file to run pipelines, test the pipeline successfully in the VP CI pipeline.