uucore, expr: centralize regex in uucore and adopt fancy-regex leftmost-longest - #14531
Draft
wtcpython wants to merge 1 commit into
Draft
uucore, expr: centralize regex in uucore and adopt fancy-regex leftmost-longest#14531wtcpython wants to merge 1 commit into
wtcpython wants to merge 1 commit into
Conversation
wtcpython
force-pushed
the
uucore-regex
branch
from
September 13, 2026 09:22
ad2619c to
8385621
Compare
xtqqczze
reviewed
Sep 13, 2026
| num-prime = "0.5.0" | ||
| num-traits = "0.2.19" | ||
| fancy-regex = { version = "0.19.1", default-features = false, features = [ | ||
| fancy-regex = { version = "0.19.2", default-features = false, features = [ |
Contributor
There was a problem hiding this comment.
perhaps we could move the feature selection to src/uucore/Cargo.toml
Merging this PR will degrade performance by 3.59%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
Footnotes
|
wtcpython
force-pushed
the
uucore-regex
branch
from
September 13, 2026 09:51
8385621 to
47d63dc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
wtcpython
force-pushed
the
uucore-regex
branch
from
September 13, 2026 11:10
47d63dc to
a427a2b
Compare
|
GNU testsuite comparison: |
…st-longest Centralize regular expression parsing and POSIX error checking into a new `uucore::regex` module behind the `regex` feature flag. Upgrade fancy-regex to 0.19.2 with the leftmost_longest feature to satisfy POSIX matching rules. Migrate uu_expr to delegate regex handling to uucore::regex::bre_to_ere.
wtcpython
force-pushed
the
uucore-regex
branch
from
September 13, 2026 13:00
a427a2b to
257233c
Compare
Contributor
|
Conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.