Skip to content

feat[agent](windows): client-configurable event channels with live reload - #2533

Open
yllada wants to merge 2 commits into
release/v11.2.14from
backlog/windows-event-channels
Open

feat[agent](windows): client-configurable event channels with live reload#2533
yllada wants to merge 2 commits into
release/v11.2.14from
backlog/windows-event-channels

Conversation

@yllada

@yllada yllada commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Windows event channels were hardcoded. They now live in
windows-event-channels.yml next to the agent executable, and changes apply in
about a second without restarting the service.

Additions only: the system channels stay in config, not in the file, so
deleting or corrupting it degrades to default collection instead of reducing
telemetry.

Changes

File Change
agent/config/const.go Default channel list and file path, shared by both architectures
agent/collector/schema/windows_channels.go Resolve/merge and the documented template. No build tags, so it is platform-independent
agent/collector/platform/windows_amd64.go Shared callback and registry, lock split, bounded retry, reconcile
agent/collector/platform/windows_arm64.go Same change, regenerated from amd64
agent/collector/configwatcher/watcher.go WatchFile takes a path and debounce; Watch wraps it with zero debounce
agent/version.json 11.1.4 → 11.1.5

A second commit updates Go dependencies across all 23 modules, which brings
go_deps back to green.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

🛑 AI review — Engineer review required

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. @Kbayero @osmontero please review.

🛑 architecture (gemini-3-flash-lite) — blocking — must fix before merge

Summary: Agent changes include new Windows event channel monitoring and runtime callback registry modifications.

  • high agent/collector/platform/windows_amd64.go:133 — Touches agent code and internal execution flows for Windows event subscription management. Any changes to agent logic or event callback mechanisms require careful validation against deployed versions to prevent agent breakage.
  • medium installer/go.mod:6 — Touches installer path, which is a critical-path component requiring senior review and a coordinated rollout plan.

bugs (gemini-3-flash-lite) — clean

Summary: Add dynamic Windows event channel config watching and reconciliation with safe callback mapping

No findings.

security (gemini-3-flash-lite) — clean

Summary: Routine dependency version bumps and implementation of dynamic Windows event channel subscription and file-watching configuration reloading.

No findings.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — AI review found blocking issues (high/critical, or engineer review required). See above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant